[receiver/opencensus] Do not report error message on clean shutdown #36622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjanotti
changed the title
dmitryax
approved these changes
Dec 3, 2024
shivanthzen
pushed a commit
to shivanthzen/opentelemetry-collector-contrib
that referenced
this pull request
Dec 5, 2024
…pen-telemetry#36622) #### Description The receiver is reporting error on a clean shutdown because it is not looking for the correct error. Besides logging a false-positive error message this can end up in a deadlock during shutdown due to open-telemetry/opentelemetry-collector#9824 #### Testing Added a test specific for that. In principle, this should be part of the generated tests, but, to do that it will be necessary to add support to the `Reporter` interface. #### Documentation Changelog.
ZenoCC-Peng
pushed a commit
to ZenoCC-Peng/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2024
…pen-telemetry#36622) #### Description The receiver is reporting error on a clean shutdown because it is not looking for the correct error. Besides logging a false-positive error message this can end up in a deadlock during shutdown due to open-telemetry/opentelemetry-collector#9824 #### Testing Added a test specific for that. In principle, this should be part of the generated tests, but, to do that it will be necessary to add support to the `Reporter` interface. #### Documentation Changelog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The receiver is reporting error on a clean shutdown because it is not looking for the correct error. Besides logging a false-positive error message this can end up in a deadlock during shutdown due to open-telemetry/opentelemetry-collector#9824
Testing
Added a test specific for that. In principle, this should be part of the generated tests, but, to do that it will be necessary to add support to the
Reporterinterface.Documentation
Changelog.