Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Throttle in X-Ray exporter. #3685

Merged
merged 2 commits into from
Jun 7, 2021

Conversation

anuraaga
Copy link
Contributor

@anuraaga anuraaga commented Jun 2, 2021

Description: Restores setting of Throttle for HTTP throttle response

Link to tracking Issue: Fixes #3684
Seems to have been lost accidentally in #1489, no big deal.

Testing: Unit tests

@anuraaga anuraaga requested a review from kbrockhoff as a code owner June 2, 2021 02:09
@anuraaga anuraaga requested a review from a team June 2, 2021 02:09
@anuraaga anuraaga requested review from mxiamxia and Aneurysm9 June 2, 2021 02:09
Copy link
Member

@mxiamxia mxiamxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@georges-git
Copy link

georges-git commented Jun 2, 2021

Would the above bug and code fix will resolve the throttle shown in the below screen shot? Would this be backported to OTEL version 0.9?
Screen Shot 2021-06-02 at 1 11 22 PM

@anuraaga anuraaga added the ready to merge Code review completed; ready to merge by maintainers label Jun 7, 2021
@bogdandrutu bogdandrutu merged commit 954d9b9 into open-telemetry:main Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

X-Ray exporter doesn't set isThrottled
5 participants