Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[splunkhecexporter]Add metric_type as key which maps to the type of the metric #3696

Merged
merged 4 commits into from
Jun 3, 2021

Conversation

Saber-W
Copy link
Member

@Saber-W Saber-W commented Jun 2, 2021

Description:
Currently, some metadata isn't stored into Splunk HEC when converting. This PR adds metric_type to the fields of Splunk event to transfer this info. The type of metric could be one of: gauge, sum, histogram or summary.

Link to tracking Issue:
#3289

Testing:
Update related unit testing Test_metricDataToSplunk.

@Saber-W Saber-W requested a review from a team June 2, 2021 16:39
@Saber-W
Copy link
Member Author

Saber-W commented Jun 2, 2021

@tigrannajaryan tigrannajaryan requested a review from atoulme June 2, 2021 20:58
@tigrannajaryan
Copy link
Member

@Saber-W lint job failed. Please make sure the build passes.

make[1]: Leaving directory '/home/circleci/project/exporter/sentryexporter'
make -C ./exporter/splunkhecexporter lint
make[1]: Entering directory '/home/circleci/project/exporter/splunkhecexporter'
golangci-lint run --allow-parallel-runners
metricdata_to_splunk_test.go:510: File is not `gofmt`-ed with `-s` (gofmt)
						"metric_type": "IntSum",
make[1]: *** [../../Makefile.Common:93: lint] Error 1
make[1]: Leaving directory '/home/circleci/project/exporter/splunkhecexporter'
make: *** [Makefile:149: for-all-target-./exporter/splunkhecexporter] Error 2
make: *** Waiting for unfinished jobs....
make[1]: Leaving directory '/home/circleci/project/exporter/signalfxexporter'

Exited with code exit status 2
CircleCI received exit code 2

@Saber-W
Copy link
Member Author

Saber-W commented Jun 2, 2021

Hi @tigrannajaryan, sure. It's the gofmt issue, which should be fixed now.

@atoulme
Copy link
Contributor

atoulme commented Jun 2, 2021

LGTM thanks for the contrib!

@tigrannajaryan tigrannajaryan merged commit bafc9ff into open-telemetry:main Jun 3, 2021
@tigrannajaryan
Copy link
Member

Thank you @Saber-W

@Saber-W
Copy link
Member Author

Saber-W commented Jun 3, 2021

Thanks!

alexperez52 referenced this pull request in open-o11y/opentelemetry-collector-contrib Aug 18, 2021
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants