-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update instrumentation naming in accordance with otel spec. #3733
Update instrumentation naming in accordance with otel spec. #3733
Conversation
Please fix lint errors:
|
You may have to just rebase (merge) to the latest head. |
6d0428d
to
4425dc1
Compare
instrumentationNameKey = "otel.library.name" | ||
instrumentationVersionKey = "otel.library.version" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are defined in conventions
package from the core Collector repo. It is probably best to just import that.
a1d3a84
to
6c2edca
Compare
@tigrannajaryan rebased again with feedback |
Looks like Jenkins is losing some UDP packets during load testing - I don't think that failure is related to this PR. |
Description: Updates instrumentation name and version key in accordance with the opentelemetry exporter specification