Added implementation of Google Cloud Spanner receiver - 4th part(actual receiver implementation). #5727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jpkrohling , tigrannajaryan, this is the final part of implementation. |
asukhyy
approved these changes
Oct 13, 2021
|
@khospodarysko please review as a codeowner. |
ydrozhdzhal
force-pushed
the
googlecloudspannerreceiver/implementation-part-4
branch
from
9c43ea0 to
b8b4ee1
Compare
ydrozhdzhal
force-pushed
the
googlecloudspannerreceiver/implementation-part-4
branch
from
b8b4ee1 to
f65dc8f
Compare
jpkrohling
reviewed
Oct 14, 2021
ydrozhdzhal
force-pushed
the
googlecloudspannerreceiver/implementation-part-4
branch
2 times, most recently
from
86abddf to
efdcd05
Compare
ydrozhdzhal
force-pushed
the
googlecloudspannerreceiver/implementation-part-4
branch
from
efdcd05 to
3532c74
Compare
|
@jpkrohling, I resolved all your comments, except one (it is still hasn't been marked as resolved), but reduced time intervals. If you explain your idea by example - I can implement it in scope of this MR, or as a future improvement. Now there is unrelated flaky test failure, issues for it was created a week ago or so(not sure if it is strictly the same, but also related to |
kostia-hospodarysko
approved these changes
Oct 15, 2021
ydrozhdzhal
force-pushed
the
googlecloudspannerreceiver/implementation-part-4
branch
3 times, most recently
from
5af9e75 to
0344b01
Compare
jpkrohling
approved these changes
Oct 18, 2021
jpkrohling
added
the
ready to merge
ydrozhdzhal
force-pushed
the
googlecloudspannerreceiver/implementation-part-4
branch
3 times, most recently
from
0744d67 to
6614f99
Compare
|
Looks like the new test is failing: Perhaps the collectData is being executed more than once, causing the wg to go negative. You can try to wrap that into a sync.Once. |
Can you point to example or is it something similar to existing code? |
|
This documentation page should have an example: https://pkg.go.dev/sync#Once . Basically, you'd have the |
tigrannajaryan
removed
the
ready to merge
|
|
asukhyy
force-pushed
the
googlecloudspannerreceiver/implementation-part-4
branch
2 times, most recently
from
af3f565 to
6bcb151
Compare
|
@tigrannajaryan - could you please trigger workflows? Thanks. |
…al receiver implementation). This part of implementation is the final one and contains actual receiver implementation. It includes reading and parsing of metadata configuration, initialization of stats readers(project, database) and collection of metrics.
ydrozhdzhal
force-pushed
the
googlecloudspannerreceiver/implementation-part-4
branch
from
6bcb151 to
193e124
Compare
There is no need for this, I recommitted changes. |
jpkrohling
approved these changes
Oct 18, 2021
|
@jpkrohling , @tigrannajaryan , it is ready to merge for now (after applying latest fixes). |
ydrozhdzhal
deleted the
googlecloudspannerreceiver/implementation-part-4
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This part of implementation is the final one and contains actual receiver implementation.
It includes reading and parsing of metadata configuration, initialization of stats readers(project, database) and collection of metrics.