-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wire up awsxrayproxy extension #5747
Conversation
Looks like this isn't the only component that isn't wired yet: $ ls -1 exporter/ > /tmp/exporters-available.txt
$ grep "github.com/open-telemetry/opentelemetry-collector-contrib" internal/components/components.go | sed 's/"//g' | grep exporter | awk -F/ '{print $5}' > /tmp/exporters-wired.txt
$ diff /tmp/exporters-*
2d1
< awscloudwatchlogsexporter
12d10
< elasticsearchexporter
16d13
< googlecloudpubsubexporter
26d22
< observiqexporter
33d28
< skywalkingexporter Would it make sense to wire them all in a single PR? |
Extensions and processors seem to be in sync, but receivers aren't:
|
I would need to dig through whether any of those are in-progress (as my awsxrayproxy was until this PR :) ). The guidelines recommend only wiring in when ready |
Sounds good, I'll open a separate issue to track that. I thought this was in connection to #5725 :-) |
Looks good @anuraaga |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to rename to awsproxy
in case we want any future service requests proxied through here? Won't block on it since i can't think of any use cases right now, but just a thought for extensibility.
Please rebase. |
…tor-contrib into wireawsxray
Thanks went ahead and renamed to awsproxy as suggested |
Please rebase |
…tor-contrib into wireawsxray
@anuraaga not sure if it was a race, but another merge is required :( |
…tor-contrib into wireawsxray
Description:
Adds awsxrayproxy to the contrib components
Link to tracking Issue:
Testing:
Documentation: