rpc.system has priority to determine aws namespace in awsxrayexporter #5833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
approved these changes
Oct 20, 2021
mx-psi
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR makes it so that
rpc.systemhas the highest priority to set thenamspacevalue of the segment. Specifically, it is used to determine if the span was made using an instrumented AWS SDK as defined in the aws instrumentation spec. Ifrpc.systemis set toaws-apithen thenamespaceis set toaws.This PR aims to be backwards compatible because if
rpc.systemis not set (as it is for some languages today) then it will fallback to checking ifaws.serviceis set.Link to tracking Issue:
Fixes #5766
Testing:
The test makes a span which does not have
aws.serviceset.Documentation:
N/A (this is just following the spec)
cc @mxiamxia @anuraaga