[datadogexporter] Fix cumulative histogram handling in distributions mode #5867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
approved these changes
Oct 22, 2021
Merged
5 tasks
mx-psi
approved these changes
Oct 22, 2021
KSerrania
added a commit
to DataDog/datadog-agent
that referenced
this pull request
Oct 22, 2021
…9623) Backport of open-telemetry/opentelemetry-collector-contrib#5867 to the `pkg/otlp` package. Fixes an issue in `mapHistogramMetrics` where the `delta` boolean wouldn't be passed to `getSketchBuckets` when the histograms mode is set to distributions. Fixes an issue in `getSketchBuckets` where buckets were not tagged by bounds when getting and setting values in the points cache (in the cumulative histogram case). This led to all buckets of an histogram sharing the same cache key, making the resulting sketch wrong. Fixes the `TestNaNMetrics` histogram case, which was missing its `ExplicitBounds` definition. Adds missing unit tests for the distributions mode.
KSerrania
added a commit
to DataDog/datadog-agent
that referenced
this pull request
Oct 22, 2021
…9623) Backport of open-telemetry/opentelemetry-collector-contrib#5867 to the `pkg/otlp` package. Fixes an issue in `mapHistogramMetrics` where the `delta` boolean wouldn't be passed to `getSketchBuckets` when the histograms mode is set to distributions. Fixes an issue in `getSketchBuckets` where buckets were not tagged by bounds when getting and setting values in the points cache (in the cumulative histogram case). This led to all buckets of an histogram sharing the same cache key, making the resulting sketch wrong. Fixes the `TestNaNMetrics` histogram case, which was missing its `ExplicitBounds` definition. Adds missing unit tests for the distributions mode.
mx-psi
added
the
ready to merge
bogdandrutu
approved these changes
Oct 22, 2021
zandrewitte
pushed a commit
to StackVista/stackstate-agent
that referenced
this pull request
Nov 17, 2022
…ataDog#9623) Backport of open-telemetry/opentelemetry-collector-contrib#5867 to the `pkg/otlp` package. Fixes an issue in `mapHistogramMetrics` where the `delta` boolean wouldn't be passed to `getSketchBuckets` when the histograms mode is set to distributions. Fixes an issue in `getSketchBuckets` where buckets were not tagged by bounds when getting and setting values in the points cache (in the cumulative histogram case). This led to all buckets of an histogram sharing the same cache key, making the resulting sketch wrong. Fixes the `TestNaNMetrics` histogram case, which was missing its `ExplicitBounds` definition. Adds missing unit tests for the distributions mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes an issue in
mapHistogramMetricswhere thedeltaboolean wouldn't be passed togetSketchBucketswhen the histograms mode is set to distributions.Fixes an issue in
getSketchBucketswhere buckets were not tagged by bounds when getting and setting values in the points cache (in the cumulative histogram case). This led to all buckets of an histogram sharing the same cache key, making the resulting sketch wrong.Fixes the
TestNaNMetricshistogram case, which was missing itsExplicitBoundsdefinition.Link to tracking Issue: n/a
Testing: Added missing unit tests for the distributions mode to cover the bugged cases.
Documentation: n/a