Mongodbatlas add metrics #5921
Merged
Mongodbatlas add metrics #5921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
reviewed
Oct 26, 2021
zenmoto
force-pushed
the
mongodbatlas_add_metrics
branch
from
2ad27b7 to
1972614
Compare
bogdandrutu
reviewed
Nov 3, 2021
| extended_documentation: MongoDB Metric BACKGROUND_FLUSH_AVG | ||
| unit: 1 | ||
| data: | ||
| type: gauge |
There was a problem hiding this comment.
Unfortunately I've found very little about this particular metric save the name. The documentation from MongoDB is what's here, I've seen reference in other documentation to it being in once place a counter, and in another the time the flush took in milliseconds. I've been unable to see this one live with ad-hoc testing to see what it reports, but I've seen enough questions of people using it for performance diagnoses that I don't want to ignore it.
bogdandrutu
reviewed
Nov 12, 2021
zenmoto
force-pushed
the
mongodbatlas_add_metrics
branch
from
3c4e678 to
8a5aaa6
Compare
Also reworded extended_documentation field to clarify intent
zenmoto
force-pushed
the
mongodbatlas_add_metrics
branch
from
ea6dc95 to
4ce9637
Compare
|
@bogdandrutu done. |
bogdandrutu
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adding metrics processing to MongoDB Atlas receiver