Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add path option for health check extension #6111

Merged

Conversation

cuichenli
Copy link
Contributor

Description: Add the ability to specify the path health check should serve.

Link to tracking Issue: Fix open-telemetry/opentelemetry-collector#3002

Testing: A few unit tests were added.

@cuichenli cuichenli requested review from a team and djaglowski November 3, 2021 03:06
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 3, 2021

CLA Signed

The committers are authorized under a signed CLA.

…tor-contrib into health-check-add-path-support
Copy link
Contributor

@MovieStoreGuy MovieStoreGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all seems rather reasonable, just a few nits that are not impacting operations.

extension/healthcheckextension/config.go Outdated Show resolved Hide resolved
@MovieStoreGuy
Copy link
Contributor

Groovy, thanks for doing the work.

We just need a maintainer to run the tests :)

Could I bother either @tigrannajaryan or @jpkrohling to run them for you :)

@jpkrohling
Copy link
Member

Tests started.

@tigrannajaryan
Copy link
Member

healthcheckextension_test.go:230: File is not `gofmt`-ed with `-s` (gofmt)

You should be able to run the tests locally, no need to wait for maintainers and for CI. Make sure make passes locally before creating a PR, see https://github.com/open-telemetry/opentelemetry-collector/blob/main/CONTRIBUTING.md#creating-a-pr

@cuichenli
Copy link
Contributor Author

healthcheckextension_test.go:230: File is not `gofmt`-ed with `-s` (gofmt)

You should be able to run the tests locally, no need to wait for maintainers and for CI. Make sure make passes locally before creating a PR, see open-telemetry/opentelemetry-collector@main/CONTRIBUTING.md#creating-a-pr

thanks, did not notice i can do that...

i have fmt the code and can either @tigrannajaryan or @jpkrohling run the test again? 🙇‍♂️

@jpkrohling
Copy link
Member

Tests started.

@cuichenli
Copy link
Contributor Author

some tests failed somehow, not sure if they are flaky tests?

@jpkrohling
Copy link
Member

Indeed, this is getting affected by #5752.

@jpkrohling
Copy link
Member

@VineethReddy02, would you like to review this one?

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@VineethReddy02
Copy link

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for a health route for each receiver endpoint
6 participants