-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add path option for health check extension #6111
Add path option for health check extension #6111
Conversation
…tor-contrib into health-check-add-path-support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all seems rather reasonable, just a few nits that are not impacting operations.
Groovy, thanks for doing the work. We just need a maintainer to run the tests :) Could I bother either @tigrannajaryan or @jpkrohling to run them for you :) |
Tests started. |
You should be able to run the tests locally, no need to wait for maintainers and for CI. Make sure |
thanks, did not notice i can do that... i have fmt the code and can either @tigrannajaryan or @jpkrohling run the test again? 🙇♂️ |
Tests started. |
some tests failed somehow, not sure if they are flaky tests? |
Indeed, this is getting affected by #5752. |
@VineethReddy02, would you like to review this one? |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
LGTM! |
Description: Add the ability to specify the path health check should serve.
Link to tracking Issue: Fix open-telemetry/opentelemetry-collector#3002
Testing: A few unit tests were added.