Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allocatable type of metrics in k8scluster receiver #6113

Merged
merged 3 commits into from
Nov 19, 2021

Conversation

manang-splunk
Copy link
Contributor

Description: Added allocatable type of metrics in k8scluster receiver

Testing: All the test cases have been updated

Documentation: Updated readme.md file

Copy link
Contributor

@MovieStoreGuy MovieStoreGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few style things on my behalf.

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 11, 2021
@dmitryax dmitryax removed the Stale label Nov 12, 2021
@manang-splunk manang-splunk force-pushed the k8scluster-receiver branch 2 times, most recently from 9091565 to 0731d2b Compare November 15, 2021 13:18
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmitryax dmitryax added the ready to merge Code review completed; ready to merge by maintainers label Nov 17, 2021
@bogdandrutu bogdandrutu merged commit 7edd135 into open-telemetry:main Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants