-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add allocatable type of metrics in k8scluster receiver #6113
Merged
bogdandrutu
merged 3 commits into
open-telemetry:main
from
manang-splunk:k8scluster-receiver
Nov 19, 2021
Merged
Add allocatable type of metrics in k8scluster receiver #6113
bogdandrutu
merged 3 commits into
open-telemetry:main
from
manang-splunk:k8scluster-receiver
Nov 19, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few style things on my behalf.
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
dmitryax
reviewed
Nov 12, 2021
manang-splunk
force-pushed
the
k8scluster-receiver
branch
2 times, most recently
from
November 15, 2021 13:18
9091565
to
0731d2b
Compare
dmitryax
reviewed
Nov 16, 2021
manang-splunk
force-pushed
the
k8scluster-receiver
branch
from
November 16, 2021 09:17
0731d2b
to
4d252f7
Compare
dmitryax
approved these changes
Nov 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dmitryax
added
the
ready to merge
Code review completed; ready to merge by maintainers
label
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Added allocatable type of metrics in k8scluster receiver
Testing: All the test cases have been updated
Documentation: Updated readme.md file