[tencentcloudexporter]move the logic of configuration check to the Va… #6211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ping @jpkrohling |
jpkrohling
reviewed
Nov 9, 2021
| credential = common.NewCredential(config.SecretID, config.SecretKey) | ||
| } | ||
| func newLogServiceClient(config *Config, logger *zap.Logger) logServiceClient { | ||
| credential := common.NewCredential(config.SecretID, config.SecretKey) |
There was a problem hiding this comment.
You had a logic before, where if the config parameters are empty, you'd read the values from an env var. This PR removes that logic. Is that on purpose?
There was a problem hiding this comment.
Yes, that piece of logic is redundant. Need to enforce restrictions declared in the configuration file.
jpkrohling
approved these changes
Nov 9, 2021
This was referenced Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lidate function
Description:
Fix #6135 (comment)
Link to tracking Issue:
Testing:
Documentation: