[exporter/datadogexporter] Take hostname into account for cache #6223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
mx-psi
force-pushed
the
mx-psi/metric-dimensions
branch
from
92461c0 to
be5d8de
Compare
mx-psi
commented
Nov 19, 2021
KSerrania
reviewed
Nov 22, 2021
KSerrania
approved these changes
Nov 23, 2021
mx-psi
added
the
ready to merge
bogdandrutu
approved these changes
Dec 2, 2021
8 tasks
jamesmoessis
pushed a commit
to atlassian-forks/opentelemetry-collector-contrib
that referenced
this pull request
Dec 8, 2021
…-telemetry#6223) * [exporter/datadogexporter] Take hostname into account for cache * Defensively copy tags on AddTags * [exporter/datadogexporter] Fix m.host and add test for this
povilasv
referenced
this pull request
in coralogix/opentelemetry-collector-contrib
Dec 19, 2022
…go prometheus exporter (#6223) * add prometheus metric prefix and constant service attributes to otel-go prometheus exporter * changelog * add telemetry attributes as resource * context and comments * remove constant labels wrapper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes a bug where cumulative metrics (histograms, monotonic sums and some summary fields) were not being transformed correctly into deltas in multi-Collector setups, since the hostname was not used as part of the cache key for old points.
This could cause incorrect values on metrics. This issue did not affect users with the
resource_attributes_as_tagsflag enabled (not the default, but seems to be common) or where the tags+host were otherwise sufficient to identify a metric.To fix this we include the hostname into the cache key, which has been refactored into a
metricsDimensionsstruct.Workaround for bug in older versions: Set
resource_attributes_as_tagstotrue.Link to tracking Issue: n/a, found when working on something else
Testing: Added unit tests; will test in end-to-end environment.