[processor/filterprocessor] Ability to filter spans #6341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
1 similar comment
|
|
|
|
CLA pending internal Sony process, should be here shortly |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Resurrecting this while waitinf ro CLA |
|
@mjallday can you remove the stale still waiting on CLA |
|
Outdated |
|
I can’t remove the stale message. I’m just an interested neutral party and not affiliated with otel project beyond creating #5838. |
|
Sorted and ready for your review / merge |
|
Hey all, My apologies on just leaving this hanging. There were some issues out of my control precluding me from finishing it up. Let me see if I can get this thing updated and fixed with the latest version. |
# Conflicts: # CHANGELOG.md # internal/coreinternal/processor/filterspan/filterspan.go # processor/filterprocessor/factory.go # processor/filterprocessor/factory_test.go
|
@dmitryax please re-open I have addressed all your feedback and updated this |
boostchicken
changed the title
Signed-off-by: John Dorman <john@boostchicken.dev>
|
@dmitryax is check-links going to block this merge? I didn't touch the links that are broken someone must have removed something from the repo? Nevermind, I was able to track down the right part to link to, it has been updated |
Signed-off-by: John Dorman <john@boostchicken.dev>
|
@dmitryax, will you give this another review when you can? |
|
Any update on this? hoping to use this feature |
pmm-sumo
reviewed
Jun 22, 2022
pmm-sumo
reviewed
Jun 22, 2022
pmm-sumo
approved these changes
Jun 22, 2022
codeboten
approved these changes
Jun 23, 2022
codeboten
referenced
this pull request
in codeboten/opentelemetry-collector-contrib
Jun 23, 2022
A few suggestions were missed in the merge of #6341, this PR addresses those.
mx-psi
pushed a commit
that referenced
this pull request
Jun 24, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John dorman@overlooked.us
Description:
Added the ability to use the filterprocessor for spans. The documentation for filter processor currently claims it can do this, however it cannot.
Issue
#5838 ... plus many more
Testing:
Tested locally, all filtering logic is tested by the filterspan internal package, this is just a re-use of that
There are also unit tests that test the filter logic, beyond the filterspan code
Documentation:
Added README.md with a usage example as well as pointing to complete documentation in the attributes processor.