-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
routingprocessor: remove broken debug log fields #6373
routingprocessor: remove broken debug log fields #6373
Conversation
@@ -394,7 +394,7 @@ func (r *router) registerTracesExporters(hostTracesExporters map[config.Componen | |||
// registerExportersForRoutes registers exporters according to the configuring | |||
// routing table, taking into account the provided map of available exporters. | |||
func (r *router) registerExportersForRoutes(available ExporterMap) error { | |||
r.logger.Debug("Registering exporters for routes", zap.Any("exporters", available)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get a list of exporter names out of this map, instead of just removing it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could but I'd need to iterate over the whole map and save it in a slice (conditionally on a log level? Can this be easily done?). Would that be ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure it's worth it -- it would certainly be helpful to know the available exporters and the requested for the route, but perhaps the extra code wouldn't be worth it...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving, but feel free to send an update to this PR if you can find a cheap and reasonable way to list the exporters. If you are OK with merging as is, let me know.
Let's leave it as is for now. As far as the "cheap and reasonable way": this is just happening on the registration when processor initializes itself so we shouldn't be that concerned about it being cheap/not cheap :) |
Description: Remove broken debug log fields in routingprocessor
The logger fields that were added as part of the last change introduced the following unwanted log output:
So let's remote them.