Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requirement for password on MySQL #6479

Merged
merged 4 commits into from
Dec 2, 2021

Conversation

Mrod1598
Copy link
Contributor

@Mrod1598 Mrod1598 commented Dec 1, 2021

Description:
Removed requirement for password and set defaults for username and endpoint.

Testing
To test manually, install mysql server and when prompted for a password, don't set one. this will default to using the unix socket. The default location on debian is /var/run/mysqld/mysqld.sock. configure the the collector to collect from that socket using root as the username.

@Mrod1598 Mrod1598 marked this pull request as ready for review December 1, 2021 17:15
@Mrod1598 Mrod1598 requested a review from djaglowski as a code owner December 1, 2021 17:15
@Mrod1598 Mrod1598 requested a review from a team December 1, 2021 17:15
receiver/mysqlreceiver/README.md Outdated Show resolved Hide resolved
receiver/mysqlreceiver/README.md Outdated Show resolved Hide resolved
@Mrod1598 Mrod1598 requested a review from djaglowski December 1, 2021 19:43
Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Mrod1598. LGTM

@djaglowski djaglowski added the ready to merge Code review completed; ready to merge by maintainers label Dec 1, 2021
@codeboten codeboten merged commit 24b0b31 into open-telemetry:main Dec 2, 2021
@Mrod1598 Mrod1598 deleted the my-sql-password branch December 2, 2021 16:28
jamesmoessis pushed a commit to atlassian-forks/opentelemetry-collector-contrib that referenced this pull request Dec 8, 2021
…etry#6479)

* Remove requirement for password

* Remove invalid config tests

* Lint

* Update Readme
povilasv referenced this pull request in coralogix/opentelemetry-collector-contrib Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants