Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/splunkhec] Remove duplication of host.name attribute #6527

Merged

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Dec 5, 2021

The duplication used to be needed for Splunk Observability to support related content links. Now it's not needed anymore. Proper attribute conversion was added in Splunk Observability backend

The duplication used to be needed for Splunk Observability to support related contend links. Now it's not needed anymore. Proper attribute conversion was added in Splunk Observability backend
@dmitryax dmitryax requested review from a team and mx-psi December 5, 2021 23:50
@dmitryax dmitryax force-pushed the remove-hec-host-duplication branch from 3cc78d9 to 606ff02 Compare December 5, 2021 23:53
@atoulme
Copy link
Contributor

atoulme commented Dec 6, 2021

LGTM

@bogdandrutu bogdandrutu merged commit a38f067 into open-telemetry:main Dec 8, 2021
@dmitryax dmitryax deleted the remove-hec-host-duplication branch December 9, 2021 22:21
PaurushGarg referenced this pull request in open-o11y/opentelemetry-collector-contrib Dec 11, 2021
The duplication used to be needed for Splunk Observability to support related contend links. Now it's not needed anymore. Proper attribute conversion was added in Splunk Observability backend
PaurushGarg referenced this pull request in open-o11y/opentelemetry-collector-contrib Dec 11, 2021
The duplication used to be needed for Splunk Observability to support related contend links. Now it's not needed anymore. Proper attribute conversion was added in Splunk Observability backend
PaurushGarg referenced this pull request in open-o11y/opentelemetry-collector-contrib Dec 14, 2021
The duplication used to be needed for Splunk Observability to support related contend links. Now it's not needed anymore. Proper attribute conversion was added in Splunk Observability backend
povilasv referenced this pull request in coralogix/opentelemetry-collector-contrib Dec 19, 2022
* Capitalize featuregate.Stage string values, remove Stage prefix

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

* Update stage_test.go

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants