-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/datadog] Deprecate service
and version
settings
#8784
[exporter/datadog] Deprecate service
and version
settings
#8784
Conversation
35ff8f8
to
0775893
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a question, otherwise LGTM.
service: myservice | ||
version: myversion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're deprecating these options, but they're technically still supported until v0.51.0. Should we keep the tests until we definitely remove these options (to prevent breaking the behavior of these options before the scheduled date)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added back this with a comment stating they are deprecated. I didn't do this originally because you need to check Config fields individually until we do #8373 (since the warnings
field is unexported)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve conflicts
Done! |
@codeboten could this be merged if it looks good? I fixed the conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @mx-psi, I missed this message and it looks like there are more conflicts to resolve :(
Should be good now :) |
There's a release in progress, so I shouldn't merge this. After the release, this PR will likely get outdated (changelog, go.mod/sum). |
This won't make it into v0.48.0, so I updated the deprecation and removal versions
Alright, will remove the 'ready to merge' label then until after v0.48.0 is done |
v0.48.0 is done, so I merged main into this branch, updated the CHANGELOG and marked as ready to merge |
Description:
Deprecate
service
andversion
settings in favor of using theservice.name
andservice.version
semantic conventions respectively.Link to tracking Issue: #8781 and #8783
Testing: Tested that deprecation warnings are logged when using these settings.
Documentation: Removed
service
andversion
from examples.