Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make sure that it uses the latest patch release available #206

Merged
merged 1 commit into from
Oct 4, 2022
Merged

make sure that it uses the latest patch release available #206

merged 1 commit into from
Oct 4, 2022

Conversation

cpanato
Copy link
Contributor

@cpanato cpanato commented Sep 30, 2022

  • make sure that it uses the latest patch release available

@cpanato
make sure that it uses the latest patch release available
1a5c3b8 
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato cpanato requested review from a team and jpkrohling September 30, 2022 08:38
@cpanato cpanato mentioned this pull request Sep 30, 2022
Closed
jpkrohling
jpkrohling reviewed Oct 3, 2022
View reviewed changes
.github/workflows/ci-goreleaser.yaml Show resolved Hide resolved
.github/workflows/ci-goreleaser.yaml
@@ -35,7 +35,8 @@ jobs:
- name: Setup Go
uses: actions/setup-go@v3
with:
go-version: 1.19.1
go-version: '1.19'
check-latest: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this being bumped by dependabot already when new versions are available? What happens here if there's a 1.20 available?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dependabot does not bump this part, it only bumps the action itself
if 1.20 is out we need to update and push a PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, dependabot will only change that part. When 1.20 is out, will we get build failures, warnings, or things like that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, we will still run go1.19 only if we upgrade to go1.20

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the review

jpkrohling
jpkrohling approved these changes Oct 4, 2022
View reviewed changes
.github/workflows/ci-goreleaser.yaml
@@ -35,7 +35,8 @@ jobs:
- name: Setup Go
uses: actions/setup-go@v3
with:
go-version: 1.19.1
go-version: '1.19'
check-latest: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification!

@jpkrohling jpkrohling merged commit e9c0841 into open-telemetry:main Oct 4, 2022
@cpanato cpanato deleted the update-setup-go-action branch October 4, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpkrohling jpkrohling jpkrohling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpanato @jpkrohling