[batchprocessor] use mdatagen for async metric

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
open-telemetry · May 27, 2024 · 48a26e4 · 48a26e4
1 parent 6364644
commit 48a26e4
Show file tree

Hide file tree

Showing 4 changed files with 43 additions and 8 deletions.
diff --git a/processor/batchprocessor/documentation.md b/processor/batchprocessor/documentation.md
@@ -30,6 +30,14 @@ Number of times the batch was sent due to a size trigger
 | ---- | ----------- | ---------- | --------- |
 | 1 | Sum | Int | true |
 
+### processor_batch_metadata_cardinality
+
+Number of distinct metadata value combinations being processed
+
+| Unit | Metric Type | Value Type | Monotonic |
+| ---- | ----------- | ---------- | --------- |
+| 1 | Sum | Int | false |
+
 ### processor_batch_timeout_trigger_send
 
 Number of times the batch was sent due to a timeout trigger

diff --git a/processor/batchprocessor/internal/metadata/generated_telemetry.go b/processor/batchprocessor/internal/metadata/generated_telemetry.go
diff --git a/processor/batchprocessor/metadata.yaml b/processor/batchprocessor/metadata.yaml
@@ -36,3 +36,10 @@ telemetry:
       unit: By
       histogram:
         value_type: int
+    processor_batch_metadata_cardinality:
+      enabled: true
+      description: Number of distinct metadata value combinations being processed
+      unit: 1
+      sum:
+        value_type: int
+        async: true
diff --git a/processor/batchprocessor/metrics.go b/processor/batchprocessor/metrics.go
@@ -66,15 +66,15 @@ func (bpt *batchProcessorTelemetry) createOtelMetrics(set component.TelemetrySet
 		meter = noopmetric.Meter{}
 	}
 
-	bpt.telemetryBuilder, err = metadata.NewTelemetryBuilder(set)
+	bpt.telemetryBuilder, err = metadata.NewTelemetryBuilder(set, metadata.WithProcessorBatchMetadataCardinalityCallback(func() int64 { return int64(currentMetadataCardinality()) }))
 	errors = multierr.Append(errors, err)
 
 	bpt.batchMetadataCardinality, err = meter.Int64ObservableUpDownCounter(
-		processorhelper.BuildCustomMetricName(typeStr, "metadata_cardinality"),
-		metric.WithDescription("Number of distinct metadata value combinations being processed"),
+		processorhelper.BuildCustomMetricName(typeStr, ""),
+		metric.WithDescription(""),
 		metric.WithUnit("1"),
 		metric.WithInt64Callback(func(_ context.Context, obs metric.Int64Observer) error {
-			obs.Observe(int64(currentMetadataCardinality()))
+
 			return nil
 		}),
 	)