You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Updating the dep requires dealing with deprecations:
Error: plog/plogotlp/grpc_test.go:39:13: SA1019: grpc.Dial is deprecated: use NewClient instead. Will be supported throughout 1.x. (staticcheck)
cc, err := grpc.Dial("bufnet",
^
Error: plog/plogotlp/grpc_test.go:44:3: SA1019: grpc.WithBlock is deprecated: this DialOption is not supported by NewClient. Will be supported throughout 1.x. (staticcheck)
grpc.WithBlock())
^
Error: plog/plogotlp/grpc_test.go:72:13: SA1019: grpc.Dial is deprecated: use NewClient instead. Will be supported throughout 1.x. (staticcheck)
cc, err := grpc.Dial("bufnet",
^
Error: plog/plogotlp/grpc_test.go:77:3: SA1019: grpc.WithBlock is deprecated: this DialOption is not supported by NewClient. Will be supported throughout 1.x. (staticcheck)
grpc.WithBlock())
^
Error: pmetric/pmetricotlp/grpc_test.go:39:13: SA1019: grpc.Dial is deprecated: use NewClient instead. Will be supported throughout 1.x. (staticcheck)
cc, err := grpc.Dial("bufnet",
^
Error: pmetric/pmetricotlp/grpc_test.go:44:3: SA1019: grpc.WithBlock is deprecated: this DialOption is not supported by NewClient. Will be supported throughout 1.x. (staticcheck)
grpc.WithBlock())
^
The text was updated successfully, but these errors were encountered:
Updating grpc.Dial -> grpc.NewClient, removing grpc.WithBlock as it's
not recommended
https://github.com/grpc/grpc-go/blob/master/Documentation/anti-patterns.md#the-wrong-way-grpcdial.
We may need to add code in the future to wait for state to be connected,
but in my local tests, there was no flakiness introduced with this
change.
Fixes#10194
---------
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
andrzej-stencel
pushed a commit
to andrzej-stencel/opentelemetry-collector
that referenced
this issue
May 27, 2024
Updating the dep requires dealing with deprecations:
The text was updated successfully, but these errors were encountered: