Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update module google.golang.org/grpc to v1.64.0 causes issues #10194

Closed
codeboten opened this issue May 21, 2024 · 0 comments · Fixed by #10211
Closed

update module google.golang.org/grpc to v1.64.0 causes issues #10194

codeboten opened this issue May 21, 2024 · 0 comments · Fixed by #10211
Labels
dependencies Pull requests that update a dependency file

Comments

@codeboten
Copy link
Contributor

Updating the dep requires dealing with deprecations:

Error: plog/plogotlp/grpc_test.go:39:13: SA1019: grpc.Dial is deprecated: use NewClient instead.  Will be supported throughout 1.x. (staticcheck)
	cc, err := grpc.Dial("bufnet",
	           ^
Error: plog/plogotlp/grpc_test.go:44:3: SA1019: grpc.WithBlock is deprecated: this DialOption is not supported by NewClient. Will be supported throughout 1.x. (staticcheck)
		grpc.WithBlock())
		^
Error: plog/plogotlp/grpc_test.go:72:13: SA1019: grpc.Dial is deprecated: use NewClient instead.  Will be supported throughout 1.x. (staticcheck)
	cc, err := grpc.Dial("bufnet",
	           ^
Error: plog/plogotlp/grpc_test.go:77:3: SA1019: grpc.WithBlock is deprecated: this DialOption is not supported by NewClient. Will be supported throughout 1.x. (staticcheck)
		grpc.WithBlock())
		^
Error: pmetric/pmetricotlp/grpc_test.go:39:13: SA1019: grpc.Dial is deprecated: use NewClient instead.  Will be supported throughout 1.x. (staticcheck)
	cc, err := grpc.Dial("bufnet",
	           ^
Error: pmetric/pmetricotlp/grpc_test.go:44:3: SA1019: grpc.WithBlock is deprecated: this DialOption is not supported by NewClient. Will be supported throughout 1.x. (staticcheck)
		grpc.WithBlock())
		^
@codeboten codeboten added the dependencies Pull requests that update a dependency file label May 21, 2024
This was referenced May 21, 2024
Merged
Merged
bogdandrutu pushed a commit that referenced this issue May 23, 2024
@codeboten
[chore] replace deprecated calls (#10211)
8a2a1a5 
Updating grpc.Dial -> grpc.NewClient, removing grpc.WithBlock as it's
not recommended
https://github.com/grpc/grpc-go/blob/master/Documentation/anti-patterns.md#the-wrong-way-grpcdial.
We may need to add code in the future to wait for state to be connected,
but in my local tests, there was no flakiness introduced with this
change.

Fixes
#10194

---------

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
andrzej-stencel pushed a commit to andrzej-stencel/opentelemetry-collector that referenced this issue May 27, 2024
@codeboten @andrzej-stencel
[chore] replace deprecated calls (open-telemetry#10211)
cdb0b6c 
Updating grpc.Dial -> grpc.NewClient, removing grpc.WithBlock as it's
not recommended
https://github.com/grpc/grpc-go/blob/master/Documentation/anti-patterns.md#the-wrong-way-grpcdial.
We may need to add code in the future to wait for state to be connected,
but in my local tests, there was no flakiness introduced with this
change.

Fixes
open-telemetry#10194

---------

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
steves-canva pushed a commit to Canva/opentelemetry-collector that referenced this issue Jun 14, 2024
@codeboten @steves-canva
[chore] replace deprecated calls (open-telemetry#10211)
cc7fc06 
Updating grpc.Dial -> grpc.NewClient, removing grpc.WithBlock as it's
not recommended
https://github.com/grpc/grpc-go/blob/master/Documentation/anti-patterns.md#the-wrong-way-grpcdial.
We may need to add code in the future to wait for state to be connected,
but in my local tests, there was no flakiness introduced with this
change.

Fixes
open-telemetry#10194

---------

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[chore] replace deprecated calls codeboten/opentelemetry-collector
1 participant
@codeboten