Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goleak test failure #10272

Closed
codeboten opened this issue May 30, 2024 · 3 comments
Closed

goleak test failure #10272

codeboten opened this issue May 30, 2024 · 3 comments

Comments

@codeboten
Copy link
Contributor

https://github.com/open-telemetry/opentelemetry-collector/actions/runs/9307269062/job/25618213331?pr=10271


goleak: Errors on successful test run: found unexpected goroutines:
[Goroutine 202 in state chan receive, with go.opentelemetry.io/collector/exporter/exporterhelper.(*batchSender).sendMergeBatch on top of the stack:
go.opentelemetry.io/collector/exporter/exporterhelper.(*batchSender).sendMergeBatch(0xc000240aa0, {0x13d20d8, 0x1a9e8c0}, {0x13cbc98, 0xc0002ae800})
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/batch_sender.go:213 +0x40e
go.opentelemetry.io/collector/exporter/exporterhelper.(*batchSender).send(0xc000240aa0, {0x13d20d8, 0x1a9e8c0}, {0x13cbc98, 0xc0002ae800})
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/batch_sender.go:151 +0xd6
go.opentelemetry.io/collector/exporter/exporterhelper.(*baseRequestSender).send(0xc000230fc0, {0x13d20d8, 0x1a9e8c0}, {0x13cbc98, 0xc0002ae800})
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/common.go:37 +0x72
go.opentelemetry.io/collector/exporter/exporterhelper.(*baseExporter).send(0xc000242b00, {0x13d20d8, 0x1a9e8c0}, {0x13cbc98, 0xc0002ae800})
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/common.go:294 +0xa7
go.opentelemetry.io/collector/exporter/exporterhelper.TestBatchSender_ShutdownDeadlock.func2()
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/batch_sender_test.go:467 +0x10f
created by go.opentelemetry.io/collector/exporter/exporterhelper.TestBatchSender_ShutdownDeadlock in goroutine 197
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/batch_sender_test.go:465 +0x51a
 Goroutine 205 in state chan receive, with go.opentelemetry.io/collector/exporter/exporterhelper.(*batchSender).sendMergeBatch on top of the stack:
go.opentelemetry.io/collector/exporter/exporterhelper.(*batchSender).sendMergeBatch(0xc000240aa0, {0x13d20d8, 0x1a9e8c0}, {0x13cbc98, 0xc000036ac0})
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/batch_sender.go:213 +0x40e
go.opentelemetry.io/collector/exporter/exporterhelper.(*batchSender).send(0xc000240aa0, {0x13d20d8, 0x1a9e8c0}, {0x13cbc98, 0xc000036ac0})
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/batch_sender.go:151 +0xd6
go.opentelemetry.io/collector/exporter/exporterhelper.(*baseRequestSender).send(0xc000230fc0, {0x13d20d8, 0x1a9e8c0}, {0x13cbc98, 0xc000036ac0})
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/common.go:37 +0x72
go.opentelemetry.io/collector/exporter/exporterhelper.(*baseExporter).send(0xc000242b00, {0x13d20d8, 0x1a9e8c0}, {0x13cbc98, 0xc000036ac0})
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/common.go:294 +0xa7
go.opentelemetry.io/collector/exporter/exporterhelper.TestBatchSender_ShutdownDeadlock.func2()
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/batch_sender_test.go:467 +0x10f
created by go.opentelemetry.io/collector/exporter/exporterhelper.TestBatchSender_ShutdownDeadlock in goroutine 197
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/batch_sender_test.go:465 +0x51a
 Goroutine 203 in state chan receive, with go.opentelemetry.io/collector/exporter/exporterhelper.(*batchSender).sendMergeBatch on top of the stack:
go.opentelemetry.io/collector/exporter/exporterhelper.(*batchSender).sendMergeBatch(0xc000240aa0, {0x13d20d8, 0x1a9e8c0}, {0x13cbc98, 0xc000036b00})
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/batch_sender.go:213 +0x40e
go.opentelemetry.io/collector/exporter/exporterhelper.(*batchSender).send(0xc000240aa0, {0x13d20d8, 0x1a9e8c0}, {0x13cbc98, 0xc000036b00})
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/batch_sender.go:151 +0xd6
go.opentelemetry.io/collector/exporter/exporterhelper.(*baseRequestSender).send(0xc000230fc0, {0x13d20d8, 0x1a9e8c0}, {0x13cbc98, 0xc000036b00})
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/common.go:37 +0x72
go.opentelemetry.io/collector/exporter/exporterhelper.(*baseExporter).send(0xc000242b00, {0x13d20d8, 0x1a9e8c0}, {0x13cbc98, 0xc000036b00})
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/common.go:294 +0xa7
go.opentelemetry.io/collector/exporter/exporterhelper.TestBatchSender_ShutdownDeadlock.func2()
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/batch_sender_test.go:467 +0x10f
created by go.opentelemetry.io/collector/exporter/exporterhelper.TestBatchSender_ShutdownDeadlock in goroutine 197
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/batch_sender_test.go:465 +0x51a
 Goroutine 206 in state chan receive, with go.opentelemetry.io/collector/exporter/exporterhelper.(*batchSender).sendMergeBatch on top of the stack:
go.opentelemetry.io/collector/exporter/exporterhelper.(*batchSender).sendMergeBatch(0xc000240aa0, {0x13d20d8, 0x1a9e8c0}, {0x13cbc98, 0xc000218b80})
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/batch_sender.go:213 +0x40e
go.opentelemetry.io/collector/exporter/exporterhelper.(*batchSender).send(0xc000240aa0, {0x13d20d8, 0x1a9e8c0}, {0x13cbc98, 0xc000218b80})
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/batch_sender.go:151 +0xd6
go.opentelemetry.io/collector/exporter/exporterhelper.(*baseRequestSender).send(0xc000230fc0, {0x13d20d8, 0x1a9e8c0}, {0x13cbc98, 0xc000218b80})
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/common.go:37 +0x72
go.opentelemetry.io/collector/exporter/exporterhelper.(*baseExporter).send(0xc000242b00, {0x13d20d8, 0x1a9e8c0}, {0x13cbc98, 0xc000218b80})
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/common.go:294 +0xa7
go.opentelemetry.io/collector/exporter/exporterhelper.TestBatchSender_ShutdownDeadlock.func2()
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/batch_sender_test.go:467 +0x10f
created by go.opentelemetry.io/collector/exporter/exporterhelper.TestBatchSender_ShutdownDeadlock in goroutine 197
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/batch_sender_test.go:465 +0x51a
 Goroutine 207 in state chan receive, with go.opentelemetry.io/collector/exporter/exporterhelper.(*batchSender).sendMergeBatch on top of the stack:
go.opentelemetry.io/collector/exporter/exporterhelper.(*batchSender).sendMergeBatch(0xc000240aa0, {0x13d20d8, 0x1a9e8c0}, {0x13cbc98, 0xc0001b2d00})
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/batch_sender.go:213 +0x40e
go.opentelemetry.io/collector/exporter/exporterhelper.(*batchSender).send(0xc000240aa0, {0x13d20d8, 0x1a9e8c0}, {0x13cbc98, 0xc0001b2d00})
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/batch_sender.go:151 +0xd6
go.opentelemetry.io/collector/exporter/exporterhelper.(*baseRequestSender).send(0xc000230fc0, {0x13d20d8, 0x1a9e8c0}, {0x13cbc98, 0xc0001b2d00})
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/common.go:37 +0x72
go.opentelemetry.io/collector/exporter/exporterhelper.(*baseExporter).send(0xc000242b00, {0x13d20d8, 0x1a9e8c0}, {0x13cbc98, 0xc0001b2d00})
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/common.go:294 +0xa7
go.opentelemetry.io/collector/exporter/exporterhelper.TestBatchSender_ShutdownDeadlock.func2()
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/batch_sender_test.go:467 +0x10f
created by go.opentelemetry.io/collector/exporter/exporterhelper.TestBatchSender_ShutdownDeadlock in goroutine 197
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/batch_sender_test.go:465 +0x51a
 Goroutine 204 in state chan receive, with go.opentelemetry.io/collector/exporter/exporterhelper.(*batchSender).sendMergeBatch on top of the stack:
go.opentelemetry.io/collector/exporter/exporterhelper.(*batchSender).sendMergeBatch(0xc000240aa0, {0x13d20d8, 0x1a9e8c0}, {0x13cbc98, 0xc000036b40})
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/batch_sender.go:213 +0x40e
go.opentelemetry.io/collector/exporter/exporterhelper.(*batchSender).send(0xc000240aa0, {0x13d20d8, 0x1a9e8c0}, {0x13cbc98, 0xc000036b40})
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/batch_sender.go:151 +0xd6
go.opentelemetry.io/collector/exporter/exporterhelper.(*baseRequestSender).send(0xc000230fc0, {0x13d20d8, 0x1a9e8c0}, {0x13cbc98, 0xc000036b40})
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/common.go:37 +0x72
go.opentelemetry.io/collector/exporter/exporterhelper.(*baseExporter).send(0xc000242b00, {0x13d20d8, 0x1a9e8c0}, {0x13cbc98, 0xc000036b40})
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/common.go:294 +0xa7
go.opentelemetry.io/collector/exporter/exporterhelper.TestBatchSender_ShutdownDeadlock.func2()
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/batch_sender_test.go:467 +0x10f
created by go.opentelemetry.io/collector/exporter/exporterhelper.TestBatchSender_ShutdownDeadlock in goroutine 197
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/batch_sender_test.go:465 +0x51a
 Goroutine 199 in state chan receive, with go.opentelemetry.io/collector/exporter/exporterhelper.(*batchSender).sendMergeBatch on top of the stack:
go.opentelemetry.io/collector/exporter/exporterhelper.(*batchSender).sendMergeBatch(0xc000240aa0, {0x13d20d8, 0x1a9e8c0}, {0x13cbc98, 0xc000218b40})
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/batch_sender.go:213 +0x40e
go.opentelemetry.io/collector/exporter/exporterhelper.(*batchSender).send(0xc000240aa0, {0x13d20d8, 0x1a9e8c0}, {0x13cbc98, 0xc000218b40})
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/batch_sender.go:151 +0xd6
go.opentelemetry.io/collector/exporter/exporterhelper.(*baseRequestSender).send(0xc000230fc0, {0x13d20d8, 0x1a9e8c0}, {0x13cbc98, 0xc000218b40})
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/common.go:37 +0x72
go.opentelemetry.io/collector/exporter/exporterhelper.(*baseExporter).send(0xc000242b00, {0x13d20d8, 0x1a9e8c0}, {0x13cbc98, 0xc000218b40})
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/common.go:294 +0xa7
go.opentelemetry.io/collector/exporter/exporterhelper.TestBatchSender_ShutdownDeadlock.func2()
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/batch_sender_test.go:467 +0x10f
created by go.opentelemetry.io/collector/exporter/exporterhelper.TestBatchSender_ShutdownDeadlock in goroutine 197
	/home/runner/work/opentelemetry-collector/opentelemetry-collector/exporter/exporterhelper/batch_sender_test.go:465 +0x51a
]
@codeboten
Copy link
Contributor Author

Possibly related to #10258 @dmitryax

@dmitryax
Copy link
Member

Funny that @bogdandrutu mentioned this in #10269 and I fixed it :)

@codeboten
Copy link
Contributor Author

Amazing! Thanks @dmitryax

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants