[chore] Remove redundant wait group from a test #10269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10269 +/- ##
==========================================
- Coverage 92.50% 92.49% -0.02%
==========================================
Files 387 387
Lines 18259 18259
==========================================
- Hits 16890 16888 -2
- Misses 1024 1025 +1
- Partials 345 346 +1 ☔ View full report in Codecov by Sentry. |
dmitryax
force-pushed
the
remove-redundant-wg
branch
from
b73a349
to
7bde195
Compare
This may fail goleak, because some of the started go routines may not finish until the end of the test. |
dmitryax
force-pushed
the
remove-redundant-wg
branch
from
7bde195
to
65d9f82
Compare
Makes sense. I simplified the test to keep only two goroutines that must finish once the batcher is shut down. This also makes the test deterministic |
dmitryax
force-pushed
the
remove-redundant-wg
branch
from
65d9f82
to
58f2938
Compare
Closed
codeboten
approved these changes
May 30, 2024
steves-canva
pushed a commit
to Canva/opentelemetry-collector
that referenced
this pull request
Jun 14, 2024
https://github.com/open-telemetry/opentelemetry-collector/pull/10258/files#r1621017272 made me wonder if the wait group is really necessary. We have another synchronization that waits for at least two requests to enter the merge function, which should be enough. So, we don't necessarily need this wait group. Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/open-telemetry/opentelemetry-collector/pull/10258/files#r1621017272 made me wonder if the wait group is really necessary. We have another synchronization that waits for at least two requests to enter the merge function, which should be enough. So, we don't necessarily need this wait group.