-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure packages from current "service" package #5564
Comments
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this issue
Jun 29, 2022
Updates open-telemetry#5564 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this issue
Jun 29, 2022
Updates open-telemetry#5564 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this issue
Jul 25, 2022
Updates open-telemetry#5564 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
that referenced
this issue
Jul 25, 2022
Updates #5564 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
This was referenced Sep 15, 2022
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this issue
Nov 29, 2022
This is to prepare to move "pipelines" as public, see open-telemetry#5564 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
This was referenced Nov 29, 2022
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this issue
Nov 29, 2022
This is to prepare to move "pipelines" as public, see open-telemetry#5564 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
that referenced
this issue
Nov 29, 2022
This is to prepare to move "pipelines" as public, see #5564 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
This was referenced Dec 12, 2022
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this issue
Dec 13, 2022
…ider] Updates open-telemetry#5564 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this issue
Dec 13, 2022
…ider] Updates open-telemetry#5564 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
jaronoff97
pushed a commit
to lightstep/opentelemetry-collector
that referenced
this issue
Dec 14, 2022
…etry#6632) This is to prepare to move "pipelines" as public, see open-telemetry#5564 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
jaronoff97
pushed a commit
to lightstep/opentelemetry-collector
that referenced
this issue
Dec 14, 2022
…ider] (open-telemetry#6768) Updates open-telemetry#5564 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
jaronoff97
pushed a commit
to lightstep/opentelemetry-collector
that referenced
this issue
Dec 14, 2022
…etry#6632) This is to prepare to move "pipelines" as public, see open-telemetry#5564 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
jaronoff97
pushed a commit
to lightstep/opentelemetry-collector
that referenced
this issue
Dec 14, 2022
…ider] (open-telemetry#6768) Updates open-telemetry#5564 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is a proposal to restructure current large "service" package with multiple dependencies, and too many features to match the configuration "service" part:
Config
struct for configuration, similar to all other components.New(context.Context, Settings)
orBuild(context.Context, Settings)
.service/telemetry.go
file.service
package will become the package that implements the current service part of the config. Which means also will implement the "Host" interface. This package will have aConfig
which will represent the current "service::" configuration.flags
will also be moved there.service/featuregate
will be moved as a top directoryfeaturegate
.Advantages:
The text was updated successfully, but these errors were encountered: