Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure packages from current "service" package #5564

Closed
5 tasks done
Tracked by #5992
bogdandrutu opened this issue Jun 21, 2022 · 0 comments
Closed
5 tasks done
Tracked by #5992

Restructure packages from current "service" package #5564

bogdandrutu opened this issue Jun 21, 2022 · 0 comments

Comments

@bogdandrutu
Copy link
Member

bogdandrutu commented Jun 21, 2022

This is a proposal to restructure current large "service" package with multiple dependencies, and too many features to match the configuration "service" part:

  • Will create a package under "service" directory for every config service subcomponent (telemetry, pipelines, extensions). These packages will follow the format:
    • Config struct for configuration, similar to all other components.
    • Will not use a "Factory" since I don't think we want necessary to allow this to be pluginable, but will offer an API like New(context.Context, Settings) or Build(context.Context, Settings).
  • Telemetry initialization logic will be moved into this package service/telemetry.go file.
  • The current service package will become the package that implements the current service part of the config. Which means also will implement the "Host" interface. This package will have a Config which will represent the current "service::" configuration.
  • Create a new "collector" package and move the current "Collector", "windows.SvcHandler", "Command", "ConfigProvider" structs and related constructors/helpers.
    • Things related to flags will also be moved there.
  • service/featuregate will be moved as a top directory featuregate.

Advantages:

  1. Better match of the features/structure with the configuration structure.
  2. Allow external parties to use a "sub-component" of the collector (telemetry, extensions, etc.). This will fix Allow overriding telemetry providers #4970
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Jun 29, 2022
Updates open-telemetry#5564

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Jun 29, 2022
Updates open-telemetry#5564

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Jul 25, 2022
Updates open-telemetry#5564

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit that referenced this issue Jul 25, 2022
Updates #5564

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Nov 29, 2022
This is to prepare to move "pipelines" as public, see open-telemetry#5564

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Nov 29, 2022
This is to prepare to move "pipelines" as public, see open-telemetry#5564

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit that referenced this issue Nov 29, 2022
This is to prepare to move "pipelines" as public, see #5564

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Dec 13, 2022
…ider]

Updates open-telemetry#5564

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Dec 13, 2022
…ider]

Updates open-telemetry#5564

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit that referenced this issue Dec 13, 2022
…ider] (#6768)

Updates #5564

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
jaronoff97 pushed a commit to lightstep/opentelemetry-collector that referenced this issue Dec 14, 2022
…etry#6632)

This is to prepare to move "pipelines" as public, see open-telemetry#5564

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
jaronoff97 pushed a commit to lightstep/opentelemetry-collector that referenced this issue Dec 14, 2022
…ider] (open-telemetry#6768)

Updates open-telemetry#5564

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
jaronoff97 pushed a commit to lightstep/opentelemetry-collector that referenced this issue Dec 14, 2022
…etry#6632)

This is to prepare to move "pipelines" as public, see open-telemetry#5564

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
jaronoff97 pushed a commit to lightstep/opentelemetry-collector that referenced this issue Dec 14, 2022
…ider] (open-telemetry#6768)

Updates open-telemetry#5564

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant