Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back usage of multimod diff #8149

Closed
mx-psi opened this issue Aug 1, 2023 · 0 comments · Fixed by #8513
Closed

Add back usage of multimod diff #8149

mx-psi opened this issue Aug 1, 2023 · 0 comments · Fixed by #8513
Assignees
@codeboten
Labels
ci-cd CI, CD, testing, build issues priority:p2 Medium release-retro Issues discussed in a release retrospective

Comments

@mx-psi
Copy link
Member

mx-psi commented Aug 1, 2023

On the v0.82.0 release cycle we reverted #8024 because multimod is returning an incorrect return code (see #8137 for details). We should fix this on multimod and add back usage of multimod diff to the release process.

cc @codeboten
@mx-psi mx-psi added priority:p2 Medium ci-cd CI, CD, testing, build issues release-retro Issues discussed in a release retrospective labels Aug 1, 2023
@codeboten codeboten self-assigned this Sep 11, 2023
This was referenced Sep 22, 2023
Closed
Merged
codeboten pushed a commit that referenced this issue Sep 25, 2023
[chore] use multimod diff (#8513)
b5b2a4b 
This is revert-ing the revert of
#8024.
This also inverses the return of `check-changes` to match the original
behaviour.

Fixes #8149

---------

Signed-off-by: Alex Boten <aboten@lightstep.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codeboten codeboten

Labels
ci-cd CI, CD, testing, build issues priority:p2 Medium release-retro Issues discussed in a release retrospective
Projects
None yet
Milestone
No milestone
2 participants
@codeboten @mx-psi