-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OTel Instrument names not conforming to otel spec #8346
Comments
This may be addressed when open-telemetry/opentelemetry-specification#3422 is closed |
It is possible (but not pretty) to work around this with Views, which do not do any validation on the stream name. |
Also, the error about "/" can be ignored. You still get a valid instrument. cc @MrAlias |
@dashpole are you saying the result is a valid instrument even with the invalid instrument name error?
|
Ah yes i see in the code that the instrument is returned regardless of what the validation returns. Is it safe to ignore this error then? |
It should be safe in the sense that the SDK will not have a problem with this (it should process the instrument measurements as before). The only issue would be downstream. If the data goes to a place that expects the instrument names to conform to the OTel spec, that expectation will not be meet. |
Updating dependencies. Includes a workaround #8346, which causes the collector to ignore instrument name errors returned from instantiating instruments in otel. --------- Signed-off-by: Alex Boten <aboten@lightstep.com>
Once open-telemetry/opentelemetry-go#4500 is released, we should be able to revert the workaround to ignore the error |
This fixes open-telemetry#8346 Signed-off-by: Alex Boten <aboten@lightstep.com>
This fixes open-telemetry#8346 Signed-off-by: Alex Boten <aboten@lightstep.com>
The OpenTelemetry instruments created for the Collector's internal metrics use a
/
separator. This breaks when trying to upgrade to the latest version of the otel go SDK as per the change: open-telemetry/opentelemetry-go#4210The text was updated successfully, but these errors were encountered: