Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore][cmd/builder] Test for unreleased versions #10030

Merged
merged 11 commits into from
May 9, 2024
Merged

[chore][cmd/builder] Test for unreleased versions #10030

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
45ef248
[chore][cmd/builder] Test for unreleased versions
evan-bradley Apr 24, 2024
e1a1ab8
Make test more comprehensive
evan-bradley Apr 26, 2024
49ecdf6
Fix comment typos
evan-bradley Apr 26, 2024
5485ac4
Update cmd/builder/internal/builder/main_test.go
evan-bradley Apr 29, 2024
61958ba
Update comments, touch up test
evan-bradley Apr 29, 2024
f6f61d0
Fix lint
evan-bradley Apr 29, 2024
a25b690
Update variables to address PR feedback
evan-bradley May 2, 2024
14f13e5
Merge remote-tracking branch 'upstream/main' into ocb-unreleased-vers…
evan-bradley May 2, 2024
7f9db86
Merge branch 'main' into ocb-unreleased-version-test
evan-bradley May 6, 2024
5b4b665
Merge branch 'main' into ocb-unreleased-version-test
evan-bradley May 6, 2024
5031708
Merge branch 'main' into ocb-unreleased-version-test
evan-bradley May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
30 changes: 30 additions & 0 deletions cmd/builder/internal/builder/main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,36 @@ func TestVersioning(t *testing.T) {
},
expectedErr: nil,
},
{
// Check that these tests won't break during a release,
// where the local version of these packages will not
// yet exist on the Go package repository.
description: "unreleased otel version",
cfgBuilder: func() Config {
cfg := NewDefaultConfig()
cfg.Verbose = true
cfg.Distribution.Go = "go"
cfg.Distribution.OtelColVersion = "1.9999.9999"
var err error
cfg.Exporters, err = parseModules([]Module{
{
GoMod: "go.opentelemetry.io/collector/exporter/otlpexporter v1.9999.9999",
},
})
require.NoError(t, err)
cfg.Receivers, err = parseModules([]Module{
{
GoMod: "go.opentelemetry.io/collector/receiver/otlpreceiver v1.9999.9999",
},
})
require.NoError(t, err)

cfg.Replaces = append(cfg.Replaces, replaces...)

return cfg
},
expectedErr: nil,
},
{
description: "old component version",
cfgBuilder: func() Config {
Expand Down