-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[builder] make retries configurable for faster tests #10035
[builder] make retries configurable for faster tests #10035
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10035 +/- ##
==========================================
+ Coverage 91.55% 91.87% +0.31%
==========================================
Files 360 360
Lines 16693 16728 +35
==========================================
+ Hits 15284 15369 +85
+ Misses 1073 1021 -52
- Partials 336 338 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Just one very minor comment :)
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
…10035) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description When running tests, waiting for `downloadModules()` to fail 3 times when that's expected adds time to the test run. This updates tests to only attempt downloading once. Note: if there's a network failure that could cause `downloadModules()` to fail when it should normally succeed. Also the wording here is `retries` when in actuality it's the number of attempts. I didn't change this to keep the log wording the same, but I can change the wording if that's preferable. <!-- Issue number if applicable --> #### Link to tracking issue this will help for adding tests for open-telemetry#9252 and open-telemetry#9896 <!--Describe what testing was performed and which tests were added.--> #### Testing Tests ran --------- Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
Description
When running tests, waiting for
downloadModules()
to fail 3 times when that's expected adds time to the test run. This updates tests to only attempt downloading once. Note: if there's a network failure that could causedownloadModules()
to fail when it should normally succeed. Also the wording here isretries
when in actuality it's the number of attempts. I didn't change this to keep the log wording the same, but I can change the wording if that's preferable.Link to tracking issue
this will help for adding tests for #9252 and #9896
Testing
Tests ran