[confmap] Add ability to set default provider #10182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10182 +/- ##
=======================================
Coverage 92.46% 92.46%
=======================================
Files 387 387
Lines 18246 18264 +18
=======================================
+ Hits 16871 16888 +17
- Misses 1028 1029 +1
Partials 347 347 ☔ View full report in Codecov by Sentry. |
TylerHelmuth
commented
May 21, 2024
Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
…lmuth/opentelemetry-collector into confmap-default-provider
bogdandrutu
reviewed
May 23, 2024
bogdandrutu
reviewed
May 28, 2024
codeboten
pushed a commit
that referenced
this pull request
May 28, 2024
#### Description Add a new test scenarios to confmap expand tests #### Link to tracking issue Related to #10182 (comment)
bogdandrutu
reviewed
May 28, 2024
bogdandrutu
approved these changes
May 29, 2024
evan-bradley
approved these changes
May 29, 2024
Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
codeboten
approved these changes
May 29, 2024
steves-canva
pushed a commit
to Canva/opentelemetry-collector
that referenced
this pull request
Jun 14, 2024
#### Description Add a new test scenarios to confmap expand tests #### Link to tracking issue Related to open-telemetry#10182 (comment)
steves-canva
pushed a commit
to Canva/opentelemetry-collector
that referenced
this pull request
Jun 14, 2024
#### Description
This PR adds support for expanding `${}` syntax when no schema is
provided by allowing Resolver to use a default provider.
In a followup PR I'll update otelcol with a feature gate that allow
switching between a default envProvider and the expandconverter.
#### Link to tracking issue
Related to
open-telemetry#10161
Related to
open-telemetry#7111
#### Testing
Added unit tests
#### Documentation
Added godoc strings
---------
Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for expanding
${}syntax when no schema is provided by allowing Resolver to use a default provider.In a followup PR I'll update otelcol with a feature gate that allow switching between a default envProvider and the expandconverter.
Link to tracking issue
Related to #10161
Related to #7111
Testing
Added unit tests
Documentation
Added godoc strings