Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] fix leak in test #10197

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

codeboten
Copy link
Contributor

This will allow enabling of goleak checks for the package.

This will allow enabling of goleak checks for the package.

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten requested a review from a team as a code owner May 21, 2024 18:14
@codeboten codeboten requested a review from mx-psi May 21, 2024 18:14
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.90%. Comparing base (d9dbfbc) to head (916707f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10197   +/-   ##
=======================================
  Coverage   91.90%   91.90%           
=======================================
  Files         361      361           
  Lines       16970    16970           
=======================================
  Hits        15596    15596           
  Misses       1032     1032           
  Partials      342      342           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codeboten codeboten merged commit d294537 into open-telemetry:main May 21, 2024
48 checks passed
@codeboten codeboten deleted the codeboten/dont-leak branch May 21, 2024 19:15
@github-actions github-actions bot added this to the next release milestone May 21, 2024
andrzej-stencel pushed a commit to andrzej-stencel/opentelemetry-collector that referenced this pull request May 27, 2024
This will allow enabling of goleak checks for the package.

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
steves-canva pushed a commit to Canva/opentelemetry-collector that referenced this pull request Jun 14, 2024
This will allow enabling of goleak checks for the package.

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants