Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mdatagen] Add basic telemetry test #10206

Conversation

jpkrohling
Copy link
Member

This PR adds basic tests for the telemetry generation, and fixes the documentation about value type being required for histograms.

Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@jpkrohling jpkrohling requested a review from a team as a code owner May 22, 2024 09:27
@jpkrohling jpkrohling requested a review from mx-psi May 22, 2024 09:27
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.97%. Comparing base (d294537) to head (9d25502).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10206      +/-   ##
==========================================
+ Coverage   91.90%   91.97%   +0.07%     
==========================================
  Files         361      361              
  Lines       16970    16970              
==========================================
+ Hits        15596    15609      +13     
+ Misses       1032     1022      -10     
+ Partials      342      339       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@songy23 songy23 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 22, 2024
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@codeboten codeboten merged commit a90fa50 into open-telemetry:main May 22, 2024
65 of 66 checks passed
@github-actions github-actions bot added this to the next release milestone May 22, 2024
andrzej-stencel pushed a commit to andrzej-stencel/opentelemetry-collector that referenced this pull request May 27, 2024
This PR adds basic tests for the telemetry generation, and fixes the
documentation about value type being required for histograms.

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
steves-canva pushed a commit to Canva/opentelemetry-collector that referenced this pull request Jun 14, 2024
This PR adds basic tests for the telemetry generation, and fixes the
documentation about value type being required for histograms.

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants