[chore] update lint configuration #10209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses some of the following warnings: ``` WARN [config_reader] The configuration option `run.skip-dirs` is deprecated, please use `issues.exclude-dirs`. WARN [config_reader] The configuration option `run.skip-dirs-use-default` is deprecated, please use `issues.exclude-dirs-use-default`. WARN [config_reader] The configuration option `output.format` is deprecated, please use `output.formats` WARN [config_reader] The configuration option `linters.govet.check-shadowing` is deprecated. Please enable `shadow` instead, if you are not using `enable-all`. WARN [config_reader] The configuration option `linters.errcheck.ignore` is deprecated, please use `linters.errcheck.exclude-functions`. ``` Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10209 +/- ##
==========================================
- Coverage 91.99% 91.97% -0.02%
==========================================
Files 361 361
Lines 16970 16970
==========================================
- Hits 15611 15609 -2
- Misses 1021 1022 +1
- Partials 338 339 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
|
Note that shadowing configuration is no longer needed as it's enabled via |
codeboten
added a commit
to codeboten/opentelemetry-collector-contrib
that referenced
this pull request
May 22, 2024
As was done in core open-telemetry/opentelemetry-collector#10209 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
songy23
approved these changes
May 22, 2024
TylerHelmuth
approved these changes
May 22, 2024
codeboten
added a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
May 22, 2024
As was done in core open-telemetry/opentelemetry-collector#10209 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
andrzej-stencel
pushed a commit
to andrzej-stencel/opentelemetry-collector
that referenced
this pull request
May 27, 2024
This addresses some of the following warnings: ``` WARN [config_reader] The configuration option `run.skip-dirs` is deprecated, please use `issues.exclude-dirs`. WARN [config_reader] The configuration option `run.skip-dirs-use-default` is deprecated, please use `issues.exclude-dirs-use-default`. WARN [config_reader] The configuration option `output.format` is deprecated, please use `output.formats` WARN [config_reader] The configuration option `linters.govet.check-shadowing` is deprecated. Please enable `shadow` instead, if you are not using `enable-all`. WARN [config_reader] The configuration option `linters.errcheck.ignore` is deprecated, please use `linters.errcheck.exclude-functions`. ``` --------- Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
steves-canva
pushed a commit
to Canva/opentelemetry-collector
that referenced
this pull request
Jun 14, 2024
This addresses some of the following warnings: ``` WARN [config_reader] The configuration option `run.skip-dirs` is deprecated, please use `issues.exclude-dirs`. WARN [config_reader] The configuration option `run.skip-dirs-use-default` is deprecated, please use `issues.exclude-dirs-use-default`. WARN [config_reader] The configuration option `output.format` is deprecated, please use `output.formats` WARN [config_reader] The configuration option `linters.govet.check-shadowing` is deprecated. Please enable `shadow` instead, if you are not using `enable-all`. WARN [config_reader] The configuration option `linters.errcheck.ignore` is deprecated, please use `linters.errcheck.exclude-functions`. ``` --------- Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jul 11, 2024
As was done in core open-telemetry/opentelemetry-collector#10209 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses some of the following warnings: