Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Remove unused ocRegistry, no longer used #10215

Merged
merged 1 commit into from
May 23, 2024

Conversation

bogdandrutu
Copy link
Member

No description provided.

@bogdandrutu bogdandrutu requested a review from a team as a code owner May 23, 2024 14:37
@bogdandrutu bogdandrutu requested a review from songy23 May 23, 2024 14:37
Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 91.99%. Comparing base (4f36589) to head (b34aaaa).
Report is 3 commits behind head on main.

Files Patch % Lines
service/telemetry.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10215   +/-   ##
=======================================
  Coverage   91.99%   91.99%           
=======================================
  Files         361      361           
  Lines       16964    16965    +1     
=======================================
+ Hits        15606    15607    +1     
  Misses       1019     1019           
  Partials      339      339           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the ocregistry was still used by some of the contrib components that use opencensus, is that no longer the case?

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bogdandrutu
Copy link
Member Author

bogdandrutu commented May 23, 2024

The stats module in opencensus it is it own producer registered, this registry was only for the process metrics :)

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I was confusing this producer registration for the one in the exporter configuration

otelprom.WithProducer(opencensus.NewMetricProducer()),

@codeboten codeboten merged commit f05f556 into open-telemetry:main May 23, 2024
38 of 49 checks passed
@github-actions github-actions bot added this to the next release milestone May 23, 2024
andrzej-stencel pushed a commit to andrzej-stencel/opentelemetry-collector that referenced this pull request May 27, 2024
steves-canva pushed a commit to Canva/opentelemetry-collector that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants