[chore] fix schema for telemetry/metrics/<metric-name> #10224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
jpkrohling
commented
May 27, 2024
| monotonic: bool | ||
| # Optional: array of attributes that were defined in the attributes section that are emitted by this metric. | ||
| attributes: [string] | ||
| metrics: |
There was a problem hiding this comment.
This is really the only difference here. Everything else was just indented under metrics.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10224 +/- ##
=======================================
Coverage 92.53% 92.53%
=======================================
Files 387 387
Lines 18191 18191
=======================================
Hits 16833 16833
Misses 1019 1019
Partials 339 339 ☔ View full report in Codecov by Sentry. |
codeboten
approved these changes
May 27, 2024
steves-canva
pushed a commit
to Canva/opentelemetry-collector
that referenced
this pull request
Jun 14, 2024
…y#10224) Apparently there's an error on the schema for the telemetry node: looking at a working example, I see this: ``` telemetry: metrics: processor_tail_sampling_sampling_decision_latency: description: Latency (in microseconds) of a given sampling policy unit: µs enabled: true histogram: value_type: int ``` However, the current schema seems to indicate that the `metrics` node shouldn't be there. This PR brings the schema to be in-line with the code. Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently there's an error on the schema for the telemetry node: looking at a working example, I see this:
However, the current schema seems to indicate that the
metricsnode shouldn't be there. This PR brings the schema to be in-line with the code.Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de