Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[component] Remove deprecated component.UnmarshalConfig #10340

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Jun 5, 2024

Description

Remove deprecated component.UnmarshalConfig

Link to tracking issue

Fixes #7102

@atoulme atoulme requested a review from a team as a code owner June 5, 2024 23:01
@atoulme atoulme requested a review from dmitryax June 5, 2024 23:01
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.58%. Comparing base (4f69539) to head (772ccc0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10340      +/-   ##
==========================================
+ Coverage   92.57%   92.58%   +0.01%     
==========================================
  Files         387      387              
  Lines       18254    18252       -2     
==========================================
  Hits        16898    16898              
+ Misses       1011     1009       -2     
  Partials      345      345              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atoulme
Copy link
Contributor Author

atoulme commented Jun 5, 2024

open-telemetry/opentelemetry-collector-contrib#33404 is open to fix contrib.

@TylerHelmuth
Copy link
Member

@atoulme looks like there are a couple more places in Contrib that need updating

@atoulme
Copy link
Contributor Author

atoulme commented Jun 6, 2024

open-telemetry/opentelemetry-collector-contrib#33407 to follow up, sorry.

@codeboten codeboten merged commit 1912879 into open-telemetry:main Jun 6, 2024
49 checks passed
@github-actions github-actions bot added this to the next release milestone Jun 6, 2024
@atoulme atoulme deleted the remove_unmarshalconfig branch June 7, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove component.UnmarshalConfig
3 participants