Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add goreleaser check and attempt update #10428

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

djaglowski
Copy link
Member

#10384 updated goreleaser to a new major version and this appears to have broken the config. This problem only became apparent during the release process since the config is not used otherwise.

This PR adds a github action to run goreleaser check on all PRs, since changes to the config may not be caught until release is attempted.

I've also included what may be the only necessary change to the config, by renaming changelog.skip to changelog.disable. This passes goreleaser check when run locally.

The monorepo section of the config fails locally, but the feature appears to require the Pro version so I'm unclear if it will pass with the OSS version.

@djaglowski
Copy link
Member Author

The new check passed, reporting a valid config here.

@djaglowski djaglowski added Skip Changelog PRs that do not require a CHANGELOG.md entry Skip Contrib Tests labels Jun 18, 2024
@djaglowski
Copy link
Member Author

I reverted the config to demonstrate that the new action fails when the config is invalid, and that changing skip to disable in the config is correct.

@djaglowski djaglowski marked this pull request as ready for review June 18, 2024 14:49
@djaglowski djaglowski requested a review from a team as a code owner June 18, 2024 14:49
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.35%. Comparing base (aa31b27) to head (6421d1d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10428   +/-   ##
=======================================
  Coverage   92.35%   92.35%           
=======================================
  Files         386      386           
  Lines       18370    18370           
=======================================
  Hits        16965    16965           
  Misses       1052     1052           
  Partials      353      353           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codeboten codeboten merged commit 9bd581b into open-telemetry:main Jun 18, 2024
40 checks passed
@github-actions github-actions bot added this to the next release milestone Jun 18, 2024
@djaglowski djaglowski deleted the update-goreleaser branch June 18, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry Skip Contrib Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants