Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release instructions #10431

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Update release instructions #10431

merged 1 commit into from
Jun 18, 2024

Conversation

djaglowski
Copy link
Member

Step 8 in the core release process references a draft PR opened in Step 1. However, Step 1 was changed somewhat recently to state that this PR should be merged before proceeding. Therefore, a new PR should be opened. Since this new PR is for contrib and no longer directly associated with a step in the core process, it makes sense to move it to Step 1 of contrib section.

Step 8 in the core release process references a draft PR opened in Step 1. However, Step 1 was changed somewhat recently to state that this PR should be merged before proceeding. Therefore, a new PR should be opened. Since this new PR is for contrib and no longer directly associated with a step in the core process, it makes sense to move it to Step 1 of contrib section.
@djaglowski djaglowski added Skip Changelog PRs that do not require a CHANGELOG.md entry Skip Contrib Tests labels Jun 18, 2024
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.35%. Comparing base (ae2ed9d) to head (58758e4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10431   +/-   ##
=======================================
  Coverage   92.35%   92.35%           
=======================================
  Files         386      386           
  Lines       18370    18370           
=======================================
  Hits        16965    16965           
  Misses       1052     1052           
  Partials      353      353           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djaglowski djaglowski marked this pull request as ready for review June 18, 2024 15:56
@djaglowski djaglowski requested review from a team and atoulme June 18, 2024 15:56
@codeboten codeboten merged commit 0ca892a into main Jun 18, 2024
43 of 59 checks passed
@codeboten codeboten deleted the move-step1 branch June 18, 2024 17:28
@github-actions github-actions bot added this to the next release milestone Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry Skip Contrib Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants