-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add consumer profiles #10464
Add consumer profiles #10464
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10464 +/- ##
=======================================
Coverage 92.33% 92.34%
=======================================
Files 393 395 +2
Lines 18647 18656 +9
=======================================
+ Hits 17218 17227 +9
Misses 1069 1069
Partials 360 360 ☔ View full report in Codecov by Sentry. |
efa1a89
to
08d4ba8
Compare
45ca9a7
to
c3a88fa
Compare
I believe the failure is unrelated to these changes. |
8bcef67
to
fe7cd2c
Compare
5a0108c
to
21912e4
Compare
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Since this is the first PR actually adding implementation for profiles after the RFC, I am going to wait a few days to let other @open-telemetry/collector-approvers chime in
For future modules, it would be great to split changes of internal-only changes and new modules into separate PRs
@open-telemetry/collector-approvers planning to merge this tomorrow if nobody blocks before then |
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This adds profiles support for consumers. <!-- Issue number if applicable --> #### Link to tracking issue Based on the discussion in open-telemetry#10375. --------- Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
Description
This adds profiles support for consumers.
Link to tracking issue
Based on the discussion in #10375.