Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move exporter into an internal package, in preparation for profiles #10527

Merged
merged 3 commits into from
Jul 18, 2024
Merged

Move exporter into an internal package, in preparation for profiles #10527

merged 3 commits into from
Jul 18, 2024

Conversation

dmathieu
Copy link
Member

@dmathieu dmathieu commented Jul 3, 2024 •
edited
Loading

Description

This splits the exporter package, so the APIs are in an internal package, and redefined publicly for logs/metrics/traces.
In preparation for adding profiles to the package.

Link to tracking issue

See #10375

cc @mx-psi

@codecov Codecov
Copy link

codecov bot commented Jul 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.82353% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.35%. Comparing base (182c610) to head (dbd4e8f).

Files Patch % Lines
exporter/internal/factory.go 97.77% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10527      +/-   ##
==========================================
+ Coverage   92.33%   92.35%   +0.01%     
==========================================
  Files         395      397       +2     
  Lines       18673    18681       +8     
==========================================
+ Hits        17242    17252      +10     
+ Misses       1070     1069       -1     
+ Partials      361      360       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmathieu dmathieu marked this pull request as ready for review July 3, 2024 12:17
@dmathieu dmathieu requested a review from a team as a code owner July 3, 2024 12:17
@dmathieu dmathieu requested a review from djaglowski July 3, 2024 12:17
@mx-psi mx-psi added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 9, 2024
@djaglowski djaglowski requested review from mx-psi and removed request for djaglowski July 11, 2024 14:33
@mx-psi mx-psi merged commit a07e6c3 into open-telemetry:main Jul 18, 2024
48 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 18, 2024
@dmathieu dmathieu deleted the internal-exporter branch July 18, 2024 09:30
@dmathieu dmathieu mentioned this pull request Jul 23, 2024
Merged
mx-psi pushed a commit that referenced this pull request Jul 30, 2024
@dmathieu
Add profiles support in exporters (#10702)
67e044b 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

This follows
#10527,
and adds profiles support into exporters.

<!-- Issue number if applicable -->
#### Link to tracking issue
See #10375
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi approved these changes

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
Profiling support
Development

Successfully merging this pull request may close these issues.
2 participants
@dmathieu @mx-psi