-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/logging] Remove logging exporter #11037
base: main
Are you sure you want to change the base?
[exporter/logging] Remove logging exporter #11037
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11037 +/- ##
==========================================
- Coverage 91.42% 91.42% -0.01%
==========================================
Files 424 422 -2
Lines 20187 20117 -70
==========================================
- Hits 18455 18391 -64
+ Misses 1348 1343 -5
+ Partials 384 383 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a bunch of references on examples in language library repositories still that mention the logging exporter. This search has a lot of false positives, but it's a good start I think: https://github.com/search?q=org%3Aopen-telemetry+%22logging%3A%22+-repo%3Aopen-telemetry%2Fopentelemetry-collector+language%3AYAML+OR+language%3AMarkdown&type=code&p=1
We also have ~18% of survey respondents from the Collector survey raw data using the logging exporter so I think we need to do this very carefully.
At a minimum I feel like we need a migration page, and a very clear error message that tells you to use the debug exporter and links you to the migration page. Additionally, it would be great to have something like #7631 before we do this (not sure if it should be a hard requirement tho).
I am blocking this until we at least have no references to the logging exporter within examples in the OpenTelemetry org
#### Description Add warning to logging exporter on startup to remind users to switch to the debug exporter. #### Link to tracking issue Related to #11037 #### Testing ![image](https://github.com/user-attachments/assets/7d9cd908-6fdf-45c4-82f0-56cce35dbcee)
This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037
This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037
This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
fc9dbdb
to
7e0bee7
Compare
c541232
to
eb4045a
Compare
@mx-psi it has been another 4 weeks with an even louder warning and @codeboten has updated a majority of the loggingexporter references in language repos. I feel we should move forward with this removal. |
649f59e
to
42001aa
Compare
Description
It is September, which means we get to remove this deprecated component.
Link to tracking issue
Related to #7769