Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/logging] Remove logging exporter #11037

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TylerHelmuth
Copy link
Member

@TylerHelmuth TylerHelmuth commented Sep 3, 2024

Description

It is September, which means we get to remove this deprecated component.

Link to tracking issue

Related to #7769

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.42%. Comparing base (296e789) to head (42001aa).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11037      +/-   ##
==========================================
- Coverage   91.42%   91.42%   -0.01%     
==========================================
  Files         424      422       -2     
  Lines       20187    20117      -70     
==========================================
- Hits        18455    18391      -64     
+ Misses       1348     1343       -5     
+ Partials      384      383       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a bunch of references on examples in language library repositories still that mention the logging exporter. This search has a lot of false positives, but it's a good start I think: https://github.com/search?q=org%3Aopen-telemetry+%22logging%3A%22+-repo%3Aopen-telemetry%2Fopentelemetry-collector+language%3AYAML+OR+language%3AMarkdown&type=code&p=1

We also have ~18% of survey respondents from the Collector survey raw data using the logging exporter so I think we need to do this very carefully.

At a minimum I feel like we need a migration page, and a very clear error message that tells you to use the debug exporter and links you to the migration page. Additionally, it would be great to have something like #7631 before we do this (not sure if it should be a hard requirement tho).

I am blocking this until we at least have no references to the logging exporter within examples in the OpenTelemetry org

codeboten pushed a commit that referenced this pull request Sep 4, 2024
#### Description

Add warning to logging exporter on startup to remind users to switch to
the debug exporter.

#### Link to tracking issue
Related to
#11037

#### Testing

![image](https://github.com/user-attachments/assets/7d9cd908-6fdf-45c4-82f0-56cce35dbcee)
codeboten added a commit to codeboten/opentelemetry-java-examples that referenced this pull request Sep 20, 2024
This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
codeboten added a commit to codeboten/opentelemetry-go-contrib that referenced this pull request Sep 20, 2024
This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037
codeboten added a commit to codeboten/opentelemetry-java-contrib that referenced this pull request Sep 20, 2024
This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
codeboten added a commit to codeboten/opentelemetry-php that referenced this pull request Sep 20, 2024
This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
codeboten added a commit to codeboten/opentelemetry-android that referenced this pull request Sep 20, 2024
This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
codeboten added a commit to codeboten/opentelemetry-cpp-contrib that referenced this pull request Sep 20, 2024
This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
codeboten added a commit to codeboten/opentelemetry-erlang-contrib that referenced this pull request Sep 20, 2024
This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
codeboten added a commit to codeboten/opentelemetry-lambda that referenced this pull request Sep 20, 2024
This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
breedx-splk pushed a commit to open-telemetry/opentelemetry-android that referenced this pull request Sep 20, 2024
This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
bryannaegele pushed a commit to open-telemetry/opentelemetry-erlang-contrib that referenced this pull request Sep 20, 2024
This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
codeboten added a commit to codeboten/opentelemetry-js-contrib that referenced this pull request Sep 20, 2024
This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
codeboten added a commit to codeboten/sig-mainframe that referenced this pull request Sep 20, 2024
This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037
brettmc pushed a commit to open-telemetry/opentelemetry-php that referenced this pull request Sep 22, 2024
This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
tylerbenson pushed a commit to open-telemetry/opentelemetry-lambda that referenced this pull request Sep 23, 2024
This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@TylerHelmuth TylerHelmuth requested a review from a team as a code owner September 24, 2024 15:11
@TylerHelmuth TylerHelmuth force-pushed the remove-logging-exporter branch 2 times, most recently from c541232 to eb4045a Compare September 24, 2024 15:15
@TylerHelmuth
Copy link
Member Author

@mx-psi it has been another 4 weeks with an even louder warning and @codeboten has updated a majority of the loggingexporter references in language repos. I feel we should move forward with this removal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants