Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Use pseudo-versions to require extensiontest #11677

Merged

Conversation

jade-guiton-dd
Copy link
Contributor

@jade-guiton-dd jade-guiton-dd commented Nov 14, 2024

Description

Now that the PR to split extensiontest into its own module (#11629) has landed, we can import the new module in an externally-resolvable way using the pseudo-version corresponding to the merge commit, similar to what I did for componenttest (#11668). After the next release (0.114.0), we will be able to use that version number instead for internal imports.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.64%. Comparing base (3fe42eb) to head (e5a8860).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11677   +/-   ##
=======================================
  Coverage   91.64%   91.64%           
=======================================
  Files         442      442           
  Lines       23746    23746           
=======================================
  Hits        21761    21761           
  Misses       1616     1616           
  Partials      369      369           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jade-guiton-dd jade-guiton-dd marked this pull request as ready for review November 15, 2024 10:23
@jade-guiton-dd jade-guiton-dd requested a review from a team as a code owner November 15, 2024 10:23
@bogdandrutu bogdandrutu merged commit b55b841 into open-telemetry:main Nov 15, 2024
66 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 15, 2024
djaglowski pushed a commit to djaglowski/opentelemetry-collector that referenced this pull request Nov 21, 2024
…y#11677)

#### Description

Now that the PR to split `extensiontest` into its own module (open-telemetry#11629)
has landed, we can import the new module in an externally-resolvable way
using the pseudo-version corresponding to the merge commit, similar to
what I did for `componenttest` (open-telemetry#11668). After the next release
(0.114.0), we will be able to use that version number instead for
internal imports.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants