Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change configtls to parse a tls.Config to allow re-using in http connections #1184

Closed
wants to merge 1 commit into from

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Jun 24, 2020

Backwards compatible change for the configuration.

@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #1184 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1184      +/-   ##
==========================================
+ Coverage   87.48%   87.50%   +0.01%     
==========================================
  Files         202      202              
  Lines       14530    14531       +1     
==========================================
+ Hits        12712    12715       +3     
+ Misses       1377     1376       -1     
+ Partials      441      440       -1     
Impacted Files Coverage Δ
config/configgrpc/configgrpc.go 100.00% <100.00%> (ø)
config/configtls/configtls.go 100.00% <100.00%> (ø)
receiver/jaegerreceiver/factory.go 91.52% <100.00%> (ø)
receiver/opencensusreceiver/config.go 94.44% <100.00%> (ø)
receiver/otlpreceiver/config.go 94.44% <100.00%> (ø)
translator/internaldata/resource_to_oc.go 76.47% <0.00%> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cddc04f...5d9d066. Read the comment docs.

…ections

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu deleted the tlsconfig branch September 22, 2020 21:02
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants