Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove vmmetrics receiver, 1y later after the hack was added #1282

Merged
merged 1 commit into from
Jul 7, 2020
Merged

Remove vmmetrics receiver, 1y later after the hack was added #1282

merged 1 commit into from
Jul 7, 2020

Conversation

bogdandrutu
Copy link
Member

No description provided.

@bogdandrutu
Remove vmmetrics receiver, 1y later after the hack was added
d5c1a74 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
james-bebbington
james-bebbington approved these changes Jul 7, 2020
View reviewed changes
Copy link
Member

@james-bebbington james-bebbington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the runtime metrics that were collected in here (e.g. memory allocs), I feel like they would make sense to belong in the internal metrics reported by the Collector by default. Do we already report them? If not, should we?

@bogdandrutu
Copy link
Member Author

@james-bebbington these metrics probably should be provided by the metrics/telemetry library that we use to instrument this service. Right now we do have some in the https://github.com/open-telemetry/opentelemetry-collector/blob/master/internal/collector/telemetry/process_telemetry.go

@bogdandrutu bogdandrutu merged commit 69bbbe5 into open-telemetry:master Jul 7, 2020
@bogdandrutu bogdandrutu deleted the rmvm branch July 7, 2020 23:53
wyTrivail pushed a commit to mxiamxia/opentelemetry-collector that referenced this pull request Jul 13, 2020
@bogdandrutu @wyTrivail
Remove vmmetrics receiver, 1y later after the hack was added (open-te…
094b878 
…lemetry#1282)

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
@rakyll @MrAlias
Minor readability fixes to the Jeager example (open-telemetry#1282)
23e32b1 
Consistency with deferring span.End, variable names.

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-bebbington james-bebbington james-bebbington approved these changes

@dmitryax dmitryax Awaiting requested review from dmitryax

@flands flands Awaiting requested review from flands

@owais owais Awaiting requested review from owais

@pjanotti pjanotti Awaiting requested review from pjanotti

@rghetia rghetia Awaiting requested review from rghetia

@tigrannajaryan tigrannajaryan Awaiting requested review from tigrannajaryan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bogdandrutu @james-bebbington