Support zipkin proto in Kafka receiver #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
pavolloffay
requested review from
bogdandrutu,
dmitryax,
james-bebbington,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
|
@marianoao would you like to review? |
Codecov Report
@@ Coverage Diff @@
## master #1646 +/- ##
==========================================
- Coverage 92.03% 92.01% -0.02%
==========================================
Files 259 259
Lines 17584 17593 +9
==========================================
+ Hits 16183 16188 +5
- Misses 992 994 +2
- Partials 409 411 +2
Continue to review full report at Codecov.
|
bogdandrutu
approved these changes
Aug 27, 2020
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pavol Loffay ploffay@redhat.com
Description:
Add support for Zipkin proto in Kafka receiver.
Created from #1584 (comment)
Link to tracking Issue:
Testing: < Describe what testing was performed and which tests were added.>
some unit tests
Documentation: < Describe the documentation added.>
Added to readme