Prometheus Receiver: Print a more informative message about 'up' metric value #1826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilebox
requested review from
bogdandrutu,
dmitryax,
james-bebbington,
owais,
pjanotti and
tigrannajaryan
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1826 +/- ##
==========================================
- Coverage 91.66% 90.78% -0.88%
==========================================
Files 262 262
Lines 18603 15900 -2703
==========================================
- Hits 17052 14435 -2617
+ Misses 1118 1037 -81
+ Partials 433 428 -5
Continue to review full report at Codecov.
|
nilebox
commented
Sep 22, 2020
| @@ -159,14 +156,6 @@ func (tr *transaction) Commit() error { | |||
| return err | |||
| } | |||
|
|
|||
| if tr.metricBuilder.hasInternalMetric { | |||
| m := ochttp.ClientRoundtripLatency.M(tr.metricBuilder.scrapeLatencyMs) | |||
There was a problem hiding this comment.
Removed redundant OC metric and related code since it must be registered via OpenCensus view to be used which we don't do in the collector.
|
@nilebox please fix lint issues. |
|
@bogdandrutu fixed. |
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
* Made copy of attribute.KeyValue * Add comments and test * move test to sdk/metric * Update CHANGELOG.md Co-authored-by: Anthony Mirabella <a9@aneurysm9.com> * Add label order assertions for final results * Update CHANGELOG PR number * Revert code changes and update docs Co-authored-by: Anthony Mirabella <a9@aneurysm9.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
0separately from other (invalid) values and print informative log message.Link to tracking Issue: Fixes #1825