2c/3 Update hostmetrics swap scraper to use new perfcounters package #1869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-bebbington
requested review from
bogdandrutu,
dmitryax,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
james-bebbington
force-pushed
the
hostmetrics-swap-perflib
branch
3 times, most recently
from
2b247ed
to
838a0ce
Compare
james-bebbington
force-pushed
the
hostmetrics-swap-perflib
branch
from
838a0ce
to
e070a84
Compare
Codecov Report
@@ Coverage Diff @@
## master #1869 +/- ##
==========================================
+ Coverage 91.23% 91.29% +0.06%
==========================================
Files 272 272
Lines 16263 16263
==========================================
+ Hits 14838 14848 +10
+ Misses 998 990 -8
+ Partials 427 425 -2
Continue to review full report at Codecov.
|
bogdandrutu
approved these changes
Sep 28, 2020
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
* Add Markdown link check * Add replacement for registry URL and clean ignored * Fix config file name * Update .markdown-link.json Co-authored-by: Anthony Mirabella <a9@aneurysm9.com> Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
…ements, and benchmark tests (open-telemetry#1869)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to tracking Issue: #973
Description:
1. Add new perflib package
2. Migrate host metrics scrapers to use new package
3. Remove third_party PDH code
Depends on #1835