Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Logging for Summary Datapoint to Logging Exporter #2084

Merged

Conversation

JasonXZLiu
Copy link
Member

Description:
This issue adds logging for the summary datapoint in the logging exporter. This is primarily added for testing purposes.

Link to tracking Issue: #1638

Resulting Logs

Metric #38
Descriptor:
     -> Name: rpc_durations_seconds
     -> Description: RPC latency distributions.
     -> Unit: s
     -> DataType: DoubleSummary
SummaryDataPoints #0
Data point labels:
     -> Namespace: rpc-app
     -> Service: rpc-app-service
     -> app: rpc-app
     -> container_name: rpc-app-cont
     -> service: exponential
StartTime: 1604691204093000000
Timestamp: 1604691234093000000
Count: 410
Sum: 0.000414
QuantileValue #0: Quantile 0.500000, Value 0.000001
QuantileValue #1: Quantile 0.900000, Value 0.000002
QuantileValue #2: Quantile 0.990000, Value 0.000005

@JasonXZLiu JasonXZLiu requested a review from a team as a code owner November 6, 2020 21:31
@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #2084 (a7eceda) into master (6c8a896) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2084      +/-   ##
==========================================
- Coverage   92.10%   92.09%   -0.01%     
==========================================
  Files         278      278              
  Lines       16977    16992      +15     
==========================================
+ Hits        15636    15649      +13     
- Misses        922      923       +1     
- Partials      419      420       +1     
Impacted Files Coverage Δ
exporter/loggingexporter/logging_exporter.go 90.44% <100.00%> (+0.47%) ⬆️
translator/internaldata/resource_to_oc.go 88.73% <0.00%> (-2.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c8a896...a7eceda. Read the comment docs.

@bogdandrutu bogdandrutu closed this Nov 7, 2020
@bogdandrutu bogdandrutu reopened this Nov 7, 2020
@JasonXZLiu JasonXZLiu force-pushed the logging_exporter_summary_metric branch from 9ecb956 to a7eceda Compare November 7, 2020 00:29
@bogdandrutu bogdandrutu self-assigned this Nov 7, 2020
@bogdandrutu bogdandrutu closed this Nov 7, 2020
@bogdandrutu
Copy link
Member

G

@bogdandrutu bogdandrutu reopened this Nov 7, 2020
@bogdandrutu bogdandrutu closed this Nov 7, 2020
@bogdandrutu bogdandrutu reopened this Nov 7, 2020
@bogdandrutu bogdandrutu closed this Nov 9, 2020
@bogdandrutu bogdandrutu reopened this Nov 9, 2020
@bogdandrutu bogdandrutu merged commit 9a674f6 into open-telemetry:master Nov 9, 2020
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants