Host Metrics receiver: use correct TCP state labels on Unix systems #2087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2087 +/- ##
==========================================
- Coverage 92.10% 92.09% -0.01%
==========================================
Files 278 278
Lines 16977 16966 -11
==========================================
- Hits 15636 15625 -11
Misses 922 922
Partials 419 419
Continue to review full report at Codecov.
|
tigrannajaryan
approved these changes
Nov 10, 2020
|
@james-bebbington thanks for the fix. |
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
…elemetry#2087) (open-telemetry#2093) * Update otel.Meter to global.Meter in Getting Started Document. (open-telemetry#2087) Signed-off-by: lastchiliarch <lastchiliarch@163.com> * Update CHANGELOG.md Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the tcp_connections metric, we want to always return a data point for each TCP state label. Unix uses slightly different TCP state labels than Windows:
This PR updates the code to set the tcp state labels based on OS. This also fixes a test that would fail intermittently on Linux if any connections were in state
CLOSEorSYN_RECVwhen the test ran, since the label value differs slightly from the Windows labels that were previously always used.I considered also making the test less restrictive (i.e. don't fail if unexpected state values are returned, and thus additional data points are created), but the test failure was very useful for detecting this bug so I have left as is for now.
Fixes #2033