Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map unset status code as per spec #2134

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Nov 12, 2020

Description:
Maps the UNSET status code according to the spec.
https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/api.md#set-status

Testing:
Unit test

Documentation:
N/A

@atoulme atoulme requested a review from a team as a code owner November 12, 2020 17:11
@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #2134 (52ae04e) into master (aab5f2c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2134      +/-   ##
==========================================
+ Coverage   92.15%   92.16%   +0.01%     
==========================================
  Files         279      279              
  Lines       16983    16983              
==========================================
+ Hits        15650    15652       +2     
+ Misses        913      912       -1     
+ Partials      420      419       -1     
Impacted Files Coverage Δ
translator/trace/jaeger/traces_to_jaegerproto.go 90.18% <100.00%> (ø)
translator/internaldata/resource_to_oc.go 91.54% <0.00%> (+2.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aab5f2c...52ae04e. Read the comment docs.

@bogdandrutu bogdandrutu merged commit b3ee314 into open-telemetry:master Nov 12, 2020
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants