Add support for slices to non-pointers, use non-nullable AnyValue #2192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
force-pushed
the
noptrslice
branch
from
d4c2ed4
to
c750bf8
Compare
Codecov Report
@@ Coverage Diff @@
## master #2192 +/- ##
==========================================
- Coverage 92.00% 91.99% -0.01%
==========================================
Files 271 271
Lines 15632 15615 -17
==========================================
- Hits 14382 14365 -17
Misses 850 850
Partials 400 400
Continue to review full report at Codecov.
|
bogdandrutu
force-pushed
the
noptrslice
branch
from
c750bf8
to
1376e55
Compare
bogdandrutu
force-pushed
the
noptrslice
branch
5 times, most recently
from
30ad42e
to
bb51759
Compare
|
@tigrannajaryan friendly ping 👍 |
Before: ``` goos: darwin goarch: amd64 pkg: go.opentelemetry.io/collector/consumer/pdata BenchmarkTracesFromOtlp BenchmarkTracesFromOtlp-16 584 1805875 ns/op 940352 B/op 29954 allocs/op PASS ``` After: ``` goos: darwin goarch: amd64 pkg: go.opentelemetry.io/collector/consumer/pdata BenchmarkTracesFromOtlp BenchmarkTracesFromOtlp-16 681 1575996 ns/op 857915 B/op 24802 allocs/op PASS ``` Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
noptrslice
branch
from
bb51759
to
6ed2e73
Compare
|
@tigrannajaryan PTAL |
tigrannajaryan
approved these changes
Nov 30, 2020
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
…y#2192) Bumps [boto3](https://github.com/boto/boto3) from 1.24.95 to 1.25.4. - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](boto/boto3@1.24.95...1.25.4) --- updated-dependencies: - dependency-name: boto3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2188
Before:
After:
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com